Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish taking advantage of sentinel-terminated pointers in the standard library #3767

Closed
andrewrk opened this issue Nov 25, 2019 · 0 comments · Fixed by #12053
Closed

Finish taking advantage of sentinel-terminated pointers in the standard library #3767

andrewrk opened this issue Nov 25, 2019 · 0 comments · Fixed by #12053
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Milestone
0.10.0

Comments

@andrewrk
Copy link
Member

Follow-up from #3728. Here are some places to start:

$ grep -RI '\b265\b' ../lib/std/
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os/linux.zig:// TODO https://github.com/ziglang/zig/issues/265
../lib/std/event/fs.zig:            /// must be null terminated. TODO https://github.com/ziglang/zig/issues/265
../lib/std/event/fs.zig:            /// must be null terminated. TODO https://github.com/ziglang/zig/issues/265
../lib/std/event/fs.zig://            // TODO https://github.com/ziglang/zig/issues/265
../lib/std/c.zig:// TODO https://github.com/ziglang/zig/issues/265 on this whole file
../lib/std/os.zig:/// TODO https://github.com/ziglang/zig/issues/265
../lib/std/os.zig:/// TODO https://github.com/ziglang/zig/issues/265
../lib/std/special/start.zig:// TODO https://github.com/ziglang/zig/issues/265
@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. standard library This issue involves writing Zig code for the standard library. labels Nov 25, 2019
@andrewrk andrewrk added this to the 0.6.0 milestone Nov 25, 2019
@andrewrk andrewrk mentioned this issue Nov 25, 2019
Merged
24 tasks
andrewrk added a commit that referenced this issue Nov 25, 2019
@andrewrk
more sentinel-terminated pointers std lib integration
29e438f 
See #3767
@andrewrk andrewrk mentioned this issue Nov 25, 2019
Closed
@raulgrell raulgrell mentioned this issue Dec 13, 2019
Closed
andrewrk pushed a commit that referenced this issue Dec 17, 2019
@raulgrell @andrewrk
[#3844 + #3767] update std.c and std.os.linux to use null-terminated …
62c8174 
…pointer types (#3900)

* #3844 update std.c functions to use null-terminated pointer types

* check linux functions

* fix callsites

* fix io test

* Add allocPrintCstr function to remove other cast
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Mar 4, 2020
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 13, 2020
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 Nov 6, 2020
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 May 19, 2021
@magurotuna magurotuna mentioned this issue Jul 9, 2022
Merged
@Vexu Vexu modified the milestones: 0.12.0, 0.10.0 Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Remove outdated TODO comment in lib/std/start.zig magurotuna/zig
2 participants
@andrewrk @Vexu