Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.0.0 #1597

Closed
wants to merge 92 commits into from
Closed

v12.0.0 #1597

wants to merge 92 commits into from

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Jan 18, 2024

Description

Version: v12.0.0

Breaking Changes

  • TSS and chain validation related queries have been moved from crosschain module to observer module:
  • PendingNonces :Changed from /zeta-chain/crosschain/pendingNonces/{chain_id}/{address} to /zeta-chain/observer/pendingNonces/{chain_id}/{address} . It returns all the pending nonces for a chain id and address. This returns the current pending nonces for the chain.
  • ChainNonces : Changed from /zeta-chain/crosschain/chainNonces/{chain_id} to/zeta-chain/observer/chainNonces/{chain_id} . It returns all the chain nonces for a chain id. This returns the current nonce of the TSS address for the chain.
  • ChainNoncesAll :Changed from /zeta-chain/crosschain/chainNonces to /zeta-chain/observer/chainNonces . It returns all the chain nonces for all chains. This returns the current nonce of the TSS address for all chains.
  • All chains now have the same observer set:
  • ObserversByChain: /zeta-chain/observer/observers_by_chain/{observation_chain} has been removed and replaced with /zeta-chain/observer/observer_set. All chains have the same observer set.
  • AllObserverMappers: /zeta-chain/observer/all_observer_mappers has been removed. /zeta-chain/observer/observer_set should be used to get observers.
  • Observer params and core params have been merged into chain params:
  • Params: /zeta-chain/observer/params no longer returns observer params. Observer params data have been moved to chain params described below.
  • GetCoreParams: Renamed into GetChainParams. /zeta-chain/observer/get_core_params moved to /zeta-chain/observer/get_chain_params.
  • GetCoreParamsByChain: Renamed into GetChainParamsForChain. /zeta-chain/observer/get_core_params_by_chain moved to /zeta-chain/observer/get_chain_params_by_chain.
  • Getting the correct TSS address for Bitcoin now requires proviidng the Bitcoin chain id:
  • GetTssAddress : Changed from /zeta-chain/observer/get_tss_address/ to /zeta-chain/observer/getTssAddress/{bitcoin_chain_id} . Optional bitcoin chain id can now be passed as a parameter to fetch the correct tss for required BTC chain. This parameter only affects the BTC tss address in the response.

Features

Fixes

Refactoring

Chores

Tests

CI

  • Removed private runners and unused GitHub Action
  • Adding typescript publishing pipeline.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This was tested in Athens3 and with Smoke testing.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

kingpinXD and others added 30 commits November 10, 2023 17:23
* sort changelogs

* refactor format

* comment
* add event index in observer inbound

* rename messages

* update method usage

* use event index

* fix cosmos-gosec

* depositor contract

* smoketest refactor

* fix contracts

* mutiple deposits smoke tests

* fix depositor

* withdrawer contract

* fix smoketest deposits

* fix withdrawer contract

* multiple withdraw test

* fix contracts

* fix withdraws

* update changelog
…stnet address format) (#1367)

* skip some more recent garbage outTx trackers

* skip garbage trackers and increase btc gas fee

* skip mainnet addresses in cctxs

* cherry picked minRelayTxFee hotfix and bitcoin testnet/mainnet address format fix

* resolve conflict

* update CHANGELOG.md for v10.1.x hotfix

---------

Co-authored-by: charliec <[email protected]>
Co-authored-by: brewmaster012 <[email protected]>
…ting easier. (#1401)

* added chain id to configs

* mapped port 26657 to localhost
* initial commit

* Added sign function and unit test

* hsm config updates

* introduce hsm mode

* added commands to get address and generate key in hsm

* skipping unit test as it will fail in CI

* ran make generate and fixed lint errors

* Update cmd/zetaclientd/hsm.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/broadcast.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/broadcast.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/hsm_signer.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/hsm_signer.go

Co-authored-by: Lucas Bertrand <[email protected]>

* Update zetaclient/hsm_signer.go

Co-authored-by: Lucas Bertrand <[email protected]>

* cleanup

* added config for hsm hotkey name and moved hsm mode flag to zetabridge cfg

* add entry to changelog.

* moved hsm to new package and added build flag for unit test

* add changelog entry

* fix lint errors

---------

Co-authored-by: Lucas Bertrand <[email protected]>
* add tests fro out ts tracker

* use getEthereumChainID function in tests

---------

Co-authored-by: Lucas Bertrand <[email protected]>
…erwriting. (#13)

* add check for existing contract address to avoid overwriting.

* Added check for redeployment of gas and asset token contracts
Added unit test for this scenario

* update changelog

---------

Co-authored-by: Lucas Bertrand <[email protected]>
* add pause check

* revert on paused

* update tests

* add smoke test check

* goimports

* changelog

* Update x/crosschain/keeper/evm_deposit.go

Co-authored-by: Charlie Chen <[email protected]>

---------

Co-authored-by: Charlie Chen <[email protected]>
… allow for rollback (#23)

* code hash request

* make generate

* udpate message

* add cli command

* udpate smoke tests

* changelog

* update message name

* add check for length

* replace log with event

* add is contract check
* remove begin block

* remove build from smoketest

* deploy system contracts message

* msg tx

* add system contract deployment in smoke tests

* start core params refactor

* changelog

* refactor chains

* config refactor

* remaining build tags

* lint issues

* lint issues 2

* gen docs

* gen docs 2

* gosec issues 1

* fix cosmos nosec

* lint issues

* fix core params check

* make generate

* fix assign

* use privnet chains by default

* fix chain fetching

* use local goerli for smoke tests

* remove unamed gosec

* address nosec

* other goerli net to rename in smoketests

* gosec

* nosec alerts

* nosec alert 2

* use Bitcoin specific network

* fix address system contracts

* add logs in test

* Add more logs

* test remaining smoke tests

* remove hardcoded ZetaChain chain ID

* remove bitcoin hardcoded values

* add back smoketests

* fix smoke test except cross chain swap

* make generate

* add log message

* fix evm swap contract

* fix unit test 1

* fix CLI tests

* make generate

* fix log error

* fix Bitcoin proof test

* fix address test

* remove network flag and improve smoke tests

* add admin group

* move core params out of genesis

* remove unnecessary RemoveInTxTrackerIfExists

* add check for contract failure

* Update x/crosschain/keeper/keeper_cross_chain_tx_vote_inbound_tx.go

Co-authored-by: Tanmay <[email protected]>

* fix install in action

* improve events for system contract deploy

* error handling for bitcoin net params

* add utility functions in common

* add stateful smoketest from source

* try test fix

* fix unit test

* fix tests

---------

Co-authored-by: Tanmay <[email protected]>
* avoid posting uncessary outtx confirmation

* updated changelog.md

* added ballot identifier in log prints

* unified tx hash variable names

* updated changelog

* updated changelog
* masked zetaclient config at startup.

* fix lint error

* add changelog entry

* added deep copy

---------

Co-authored-by: Lucas Bertrand <[email protected]>
* separated evm/btc cctx schedulers in two different functions

* resolve PR comments

* sync with develop

---------

Co-authored-by: Tanmay <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
* add min gas price to feemarket module at genesis

* make zetaclient respect feemarket base fee

* add min gas price to feemarket module at genesis

* add a nil check

* add a default base gas price

* rename GetGasPrice

* fix build flag in smoketest

* fix fee in smoketest broadcast

* special ante handler for tx with only 1 msg

* add changelog

* make linter happy

* allow MsgCreateValidator to bypass min gas price check only at genesis time

* add more gas limit to address out of gas in smoketest

* fix linter complaint

* uncomment multiple deposit smoketest

* increase smoketest timeout to 35min

---------

Co-authored-by: brewmaster012 <>
…ery` and `msg_server` (#60)

* out tx tracker

* gas price

* chain nonces

* refactor nonces

* last block height

* rename some files

* add comment

* some changes in fungible module

* observer part 1

* remaining queries

* remove unused messages

* fix errors from removed messages

* update changelog

* remove grpc zevm
lumtis and others added 22 commits January 11, 2024 13:19
…tion error (#1558)

* change log level for gas stability pool iteration error

* changelog
* cherry picked hot fixes from v11.0.x

* update changelog
…enable header verification (#1552)

* required group function

* require function tests

* update message logic

* add changelog
…plicate (#1536)

* add finalized inbound

* fix lint

* fix unit test

* changelog entry

* add function to generate key for finalized inbound

* add proto files

* add simple test for evm deposit

* add todo for improving unit tests

* generate files

* add nosec

* add genesis inmport export form Finalzied inbounds

* add log lines

* avoid creation of ballots during double spend

* add changelog entry

* remove changelog entry

---------

Co-authored-by: Lucas Bertrand <[email protected]>
…workflows (#1564)

* chore(deps): bump tj-actions/changed-files in /.github/workflows

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 39 to 41.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v39...v41)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog.md

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christopher Fuka <[email protected]>
Co-authored-by: Lucas Bertrand <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0.
- [Commits](golang/net@v0.10.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lucas Bertrand <[email protected]>
…#1568)

Bumps [github.com/dvsekhvalnov/jose2go](https://github.com/dvsekhvalnov/jose2go) from 1.5.0 to 1.6.0.
- [Commits](dvsekhvalnov/jose2go@v1.5...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/dvsekhvalnov/jose2go
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.55.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.55.0...v1.56.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lucas Bertrand <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.10.0 to 0.17.0.
- [Commits](golang/crypto@v0.10.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: lumtis <[email protected]>
* move migration script

* update tests

* add monitoring for vote tx results

* changelog entry

* fix invalid contract setup

* fix smoke tests

* optimize zeta deposit

* latest experimentation

* revert back e2e tests

* add migration script for finalized inbound

* add tests

* goimport

* lint issues

* reformat breaking changes

* fix typo

---------

Co-authored-by: Charlie Chen <[email protected]>
… checks (#1557)

* remove check

* changelog

* fix goimport
… receipt (#1570)

* avoid voting on wrong ballots due to false blockNumber in EVM tx receipt

* update changelog
* fix crash due to out of bound

* use GetLastBlockHeightScanned() instead

* fixed ChainParams equality check and added changelog entry

---------

Co-authored-by: Charlie Chen <[email protected]>
Co-authored-by: Charlie Chen <[email protected]>
* add chain params equal functions

* fix param change check

* goimport

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.