replaces PR #13 for merge #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have two set of proto message; one datatype and one voter. Here we try to reduce that to 1.
1. as voter for MetaClient to vote on a observed Send event; 2. as consensus Send structure 3. as voter for MetaClient to vote on a observed Send confirmation; 4. as consensus of Send tx confirmation on external chains
MetaClient watch receive type for outbound tx; once the outbound tx is confirmed, it sends receiveConfirm msg (to be introduced in later commit) Once enough voters votes on receiveConfirm, it's considered confirmed. MetaClient needs to make sure not to double sign and not to drop and "receive" outbound.
lumtis
pushed a commit
that referenced
this pull request
Dec 18, 2023
* avoid posting uncessary outtx confirmation * updated changelog.md * added ballot identifier in log prints * unified tx hash variable names * updated changelog * updated changelog
lumtis
pushed a commit
that referenced
this pull request
Dec 19, 2023
* avoid posting uncessary outtx confirmation * updated changelog.md * added ballot identifier in log prints * unified tx hash variable names * updated changelog * updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #13 because #13 has hard to resolve conflict after merging other PRs.