Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Whitelist ERC20 Cli. #1425

Merged
merged 32 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
957babe
feat: add whitelist erc20 cli
lukema95 Dec 6, 2023
5dbfcb1
chore: modify comment
lukema95 Dec 6, 2023
618caa2
docs: add cli docs
lukema95 Dec 6, 2023
15bdf7e
fix lint
lukema95 Dec 6, 2023
a149614
update cli docs
lukema95 Dec 6, 2023
de34a16
remove ValidateBasic in cli
lukema95 Dec 11, 2023
029ef1b
Merge remote-tracking branch 'upstream/develop' into add-missing-cli
lukema95 Dec 22, 2023
c1e56fb
update cli docs
lukema95 Dec 22, 2023
ffc7ee3
remove irrelevant changes
lukema95 Jan 3, 2024
d940f18
remove irrelevant changes
lukema95 Jan 3, 2024
4d38d5a
Merge branch 'zeta-chain:develop' into add-missing-cli
lukema95 Jan 3, 2024
b4a80d9
Update changelog.md
lukema95 Jan 3, 2024
22b375a
rename cli
lukema95 Jan 3, 2024
5e1c0bc
update cli docs
lukema95 Jan 3, 2024
a4a007e
update cli docs
lukema95 Jan 3, 2024
a2d6bae
rename cli func
lukema95 Jan 3, 2024
b42e727
Merge branch 'develop' into add-missing-cli
lumtis Jan 4, 2024
fd58a77
Update x/crosschain/client/cli/cli_whitelist_erc20.go
lumtis Feb 7, 2024
7333842
Merge branch 'develop' into add-missing-cli
lumtis Feb 7, 2024
de278b4
generate cli docs
lukema95 Feb 7, 2024
93d2c5c
fix the integer overflow warning from cosmos-sec
lukema95 Feb 7, 2024
344a23a
update changelog
lukema95 Feb 9, 2024
6d6a008
Merge branch 'develop' into add-missing-cli
lukema95 Feb 9, 2024
3150ed1
make generate
lukema95 Feb 9, 2024
4e01307
make generate
lukema95 Feb 9, 2024
9b2f5b8
update changelog
lukema95 Feb 9, 2024
b1b654a
Merge remote-tracking branch 'upstream/develop' into add-missing-cli
lukema95 Feb 10, 2024
87deae0
Merge branch 'develop' into add-missing-cli
lukema95 Feb 19, 2024
58d79f8
fix generated file error
lukema95 Feb 20, 2024
39d40d7
Merge branch 'develop' into add-missing-cli
lumtis Feb 20, 2024
755b88d
fix generated file error
lukema95 Feb 21, 2024
8cce7c1
Merge branch 'develop' into add-missing-cli
lumtis Feb 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
* Made adjustments to the docker-compose for launching mainnet full nodes to include examples of using the docker images build from the docker image build pipeline.
* [1736](https://github.com/zeta-chain/node/pull/1736) - chore: add Ethermint endpoints to OpenAPI

### Features

* [1425](https://github.com/zeta-chain/node/pull/1425) add `whitelist-erc20` command

### Chores

* [1729](https://github.com/zeta-chain/node/pull/1729) - add issue templates
Expand Down
2 changes: 0 additions & 2 deletions common/common.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions docs/cli/zetacored/zetacored_tx_crosschain.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ zetacored tx crosschain [flags]
* [zetacored tx crosschain refund-aborted](zetacored_tx_crosschain_refund-aborted.md) - Refund an aborted tx , the refund address is optional, if not provided, the refund will be sent to the sender/tx origin of the cctx.
* [zetacored tx crosschain remove-from-out-tx-tracker](zetacored_tx_crosschain_remove-from-out-tx-tracker.md) - Remove a out-tx-tracker
* [zetacored tx crosschain update-tss-address](zetacored_tx_crosschain_update-tss-address.md) - Create a new TSSVoter
* [zetacored tx crosschain whitelist-erc20](zetacored_tx_crosschain_whitelist-erc20.md) - Add a new erc20 token to whitelist

52 changes: 52 additions & 0 deletions docs/cli/zetacored/zetacored_tx_crosschain_whitelist-erc20.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
# tx crosschain whitelist-erc20

Add a new erc20 token to whitelist

```
zetacored tx crosschain whitelist-erc20 [erc20Address] [chainID] [name] [symbol] [decimals] [gasLimit] [flags]
```

### Options

```
-a, --account-number uint The account number of the signing account (offline mode only)
--aux Generate aux signer data instead of sending a tx
-b, --broadcast-mode string Transaction broadcasting mode (sync|async|block)
--dry-run ignore the --gas flag and perform a simulation of a transaction, but don't broadcast it (when enabled, the local Keybase is not accessible)
--fee-granter string Fee granter grants fees for the transaction
--fee-payer string Fee payer pays fees for the transaction instead of deducting from the signer
--fees string Fees to pay along with transaction; eg: 10uatom
--from string Name or address of private key with which to sign
--gas string gas limit to set per-transaction; set to "auto" to calculate sufficient gas automatically. Note: "auto" option doesn't always report accurate results. Set a valid coin value to adjust the result. Can be used instead of "fees". (default 200000)
--gas-adjustment float adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored (default 1)
--gas-prices string Gas prices in decimal format to determine the transaction fee (e.g. 0.1uatom)
--generate-only Build an unsigned transaction and write it to STDOUT (when enabled, the local Keybase only accessed when providing a key name)
-h, --help help for whitelist-erc20
--keyring-backend string Select keyring's backend (os|file|kwallet|pass|test|memory)
--keyring-dir string The client Keyring directory; if omitted, the default 'home' directory will be used
--ledger Use a connected Ledger device
--node string [host]:[port] to tendermint rpc interface for this chain
--note string Note to add a description to the transaction (previously --memo)
--offline Offline mode (does not allow any online functionality)
-o, --output string Output format (text|json)
-s, --sequence uint The sequence number of the signing account (offline mode only)
--sign-mode string Choose sign mode (direct|amino-json|direct-aux), this is an advanced feature
--timeout-height uint Set a block timeout height to prevent the tx from being committed past a certain height
--tip string Tip is the amount that is going to be transferred to the fee payer on the target chain. This flag is only valid when used with --aux, and is ignored if the target chain didn't enable the TipDecorator
-y, --yes Skip tx broadcasting prompt confirmation
```

### Options inherited from parent commands

```
--chain-id string The network chain ID
--home string directory for config and data
--log_format string The logging format (json|plain)
--log_level string The logging level (trace|debug|info|warn|error|fatal|panic)
--trace print out full stack trace on errors
```

### SEE ALSO

* [zetacored tx crosschain](zetacored_tx_crosschain.md) - crosschain transactions subcommands

64 changes: 64 additions & 0 deletions x/crosschain/client/cli/cli_whitelist_erc20.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
package cli

import (
"fmt"
"strconv"

"github.com/cosmos/cosmos-sdk/client"
"github.com/cosmos/cosmos-sdk/client/flags"
"github.com/cosmos/cosmos-sdk/client/tx"
"github.com/spf13/cobra"
"github.com/zeta-chain/zetacore/x/crosschain/types"
)

func CmdWhitelistERC20() *cobra.Command {
cmd := &cobra.Command{
Use: "whitelist-erc20 [erc20Address] [chainID] [name] [symbol] [decimals] [gasLimit]",
Short: "Add a new erc20 token to whitelist",
Args: cobra.ExactArgs(6),
RunE: func(cmd *cobra.Command, args []string) error {
clientCtx, err := client.GetClientTxContext(cmd)
if err != nil {
return err
}

erc20Address := args[0]
chainID, err := strconv.ParseInt(args[1], 10, 64)
if err != nil {
return err
}

name := args[2]
symbol := args[3]
decimals, err := strconv.ParseUint(args[4], 10, 32)
if err != nil {
return err
}
if decimals > 128 {
return fmt.Errorf("decimals must be less than 128")
}

gasLimit, err := strconv.ParseInt(args[5], 10, 64)
if err != nil {
return err
}

msg := types.NewMsgWhitelistERC20(
clientCtx.GetFromAddress().String(),
erc20Address,
chainID,
name,
symbol,
// #nosec G701 always in range
uint32(decimals),
gasLimit,
)

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
}

flags.AddTxFlagsToCmd(cmd)

return cmd
}
1 change: 1 addition & 0 deletions x/crosschain/client/cli/tx.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ func GetTxCmd() *cobra.Command {
CmdUpdateTss(),
CmdMigrateTssFunds(),
CmdAddToInTxTracker(),
CmdWhitelistERC20(),
CmdAbortStuckCCTX(),
CmdRefundAborted(),
)
Expand Down
4 changes: 2 additions & 2 deletions x/crosschain/types/tx.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading