-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Whitelist ERC20 Cli. #1425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Just left a few comment.
We should also add an entry in changelog.md
file for the new command
all done |
@lukema95 I think it is ready to be merged.
|
all done |
Seems like |
@lumtis I run |
It seems there are some differences in the proto generation. What
I have |
@lumtis I switched buf to 1.28.0 and still nothing has changed. Can you try it to see if you can generate the correct file? |
This is curious, from the logs it seems you proto generation doesn't add addition lines in
|
done |
😂It's weird. Do I need to manually fix the error for Proof again? It is not clear how many such errors there are. |
Yeah, you can do the same thing with Proof and see if it passes |
Description
Add Whitelist ERC20 Cli. #1356
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: