V3 launch #210
Merged
V3 launch #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
msub2
commented
May 23, 2024
•
msub2
commented
- Removed beta overrides for all but one of the trial spaces
- Bumped all public package versions to 3.0.0
- Adjust a couple of deprecated WLE calls
- Adjust retry count tracking to account for multiple banners at once properly
- Update tests
|
Fixed the issue with image tests failing but the navigation one is still timing out. Looking into it |
| ]; | ||
|
|
||
| const getV3BetaUnitInfo = (adUnitId) => { | ||
| return betaUnits.find(unit => unit.id === adUnitId) || {}; | ||
| const getOverrideUnitInfo = (adUnitId) => { |
There was a problem hiding this comment.
What exactly are we overriding if we're removing the list of beta ad units?
utils/networking.js
Outdated
| @@ -62,6 +62,10 @@ const getDefaultBanner = (format, style, shouldOverride, overrideFormat) => { | |||
| } | |||
|
|
|||
| const fetchCampaignAd = async (adUnitId, format = 'tall', style = 'standard') => { | |||
| if (['tall', 'wide', 'square'].includes(format)) { | |||
| console.warn(`The old Zesty banner formats (tall, wide, and square) are being deprecated and will be removed in a future version. Please update to one of the new IAB formats (mobile-phone-interstitial, billboard, and medium-rectangle).`); | |||
There was a problem hiding this comment.
Might be helpful to link them to docs from here?
There was a problem hiding this comment.
Ah true, will add that
- We still need to keep the size override until that space can update to a newer format. Once they do the override will no longer apply and it can be removed in a subsequent release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.