Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bool return type in stubs #2272

Closed
Jeckerson opened this issue Sep 11, 2021 · 0 comments · Fixed by #2300
Closed

Fix bool return type in stubs #2272

Jeckerson opened this issue Sep 11, 2021 · 0 comments · Fixed by #2300
Assignees
Labels
bug enhancement Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details ide
Milestone

Comments

@Jeckerson
Copy link
Member

Example from Phalcon:

/**
     * Sets the dirty state of the object using one of the DIRTY_STATE_
     * constants
     *
     * @param int $dirtyState
     * @return 0|ModelInterface
     */
    public function setDirtyState(int $dirtyState);

Should be

/**
     * Sets the dirty state of the object using one of the DIRTY_STATE_
     * constants
     *
     * @param int $dirtyState
     * @return bool|ModelInterface
     */
    public function setDirtyState(int $dirtyState);
@Jeckerson Jeckerson added this to the 0.14.x milestone Sep 11, 2021
@Jeckerson Jeckerson self-assigned this Sep 11, 2021
@Jeckerson Jeckerson modified the milestones: 0.14.x, 0.14.0 Sep 12, 2021
@Jeckerson Jeckerson modified the milestones: 0.14.0, 0.15.0 Oct 3, 2021
@Jeckerson Jeckerson added the Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details label Oct 3, 2021
AlexNDRmac added a commit that referenced this issue Oct 4, 2021
@Jeckerson Jeckerson linked a pull request Oct 4, 2021 that will close this issue
3 tasks
Jeckerson added a commit that referenced this issue Oct 4, 2021
AlexNDRmac added a commit that referenced this issue Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details ide
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant