#2272 - Minor refactor in MethodDocBlock:parseMethodParameters()

zephir-lang · Oct 4, 2021 · 771e1e5 · 771e1e5
1 parent 6c41587
commit 771e1e5
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/Library/Stubs/MethodDocBlock.php b/Library/Stubs/MethodDocBlock.php
@@ -247,31 +247,28 @@ private function appendReturnLine(): void
         }
     }
 
-    private function parseMethodParameters(ClassMethod $method)
+    private function parseMethodParameters(ClassMethod $method): void
     {
         $parameters = $method->getParameters();
         $aliasManager = $method->getClassDefinition()->getAliasManager();
 
-        if (!$parameters) {
+        if ($parameters === null) {
             return;
         }
 
-        foreach ($method->getParameters() as $parameter) {
+        foreach ($parameters as $parameter) {
             if (isset($parameter['cast'])) {
                 if ($aliasManager->isAlias($parameter['cast']['value'])) {
                     $type = '\\'.$aliasManager->getAlias($parameter['cast']['value']);
                 } else {
                     $type = $parameter['cast']['value'];
                 }
             } elseif (isset($parameter['data-type'])) {
-                if ('variable' == $parameter['data-type']) {
-                    $type = 'mixed';
-                } else {
-                    $type = $parameter['data-type'];
-                }
+                $type = 'variable' === $parameter['data-type'] ? 'mixed' : $parameter['data-type'];
             } else {
                 $type = 'mixed';
             }
+
             $this->parameters['$'.trim($parameter['name'], '$')] = [$type, ''];
         }
     }