Upgrades rdkafka gem #283
Merged
Upgrades rdkafka gem #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonmaia
force-pushed
the
lmaia/rdkafka_upgrade
branch
from
e81998e to
1ec0568
Compare
dasch
reviewed
Feb 16, 2022
dasch
reviewed
Feb 16, 2022
leonmaia
force-pushed
the
lmaia/rdkafka_upgrade
branch
from
1ec0568 to
2602baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally created here #274
Description
This upgrade will require us to remove support from ruby 2.4 and 2.5, given that the rdkafka gem dropped support for these versions in the latest upgrade.
This PR upgrades Racecar to use version 0.11.1 of the rdkafka gem which bumps the Librdkafka library to the version 1.8.2 (release notes).
The main benefit of this upgrade is to try to address some issues with hanging consumers. librdkafka 1.8.0 release notes describe a couple fixes that had been done in regards to that.