-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INGEST-76] Updating to librdkafka 1.8.2 #274
Conversation
d6cd614
to
7fcfdb8
Compare
7fcfdb8
to
0eb9029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 👍 if we can either avoid the bump to the required Ruby version or have a good reason for it.
@@ -12,7 +12,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
ruby-version: ["2.4", "2.5", "2.6", "3.0"] | |||
ruby-version: ["2.6", "3.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? That's breaking any existing client on an older version of Ruby, so we'd need a reason, and an entry in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need to add into the change log that rdkafka 0.11.0 requires ruby 2.6+ (https://rubygems.org/gems/rdkafka/versions/0.11.0). i was trying to get CI to pass, so i updated that collection, but couldn't find the definition that ensure the project passed on ruby 2.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 can you also rebase on latest master?
Hey @darena-zendesk this is just a gentle bump on this PR 😅, could you rebase this with master? This change is very helpful and I know of a couple teams including mine that would love to have this merged as soon as possible 😄. |
Merged on #283 |
Why?
My team (@zendesk/ingest) maintains the support views pipeline that uses Racecar. Our consumers hang often and never recover. As a first step, we would like to upgrade Racecar to use the latest for rdkafka-ruby (0.11.0) which upgrades librdkafka to 1.8.2. Librdkafka 1.8.0 change log contains changes in this area.
References:
How?
I made the following changes:
racecar.gemspec
to require rdkafka 0.11.0Gemfile.lock
that were generated by runningbin/setup
Testing
I followed the instructions for setting up the Racecar development environment in the README and confirmed (dockerized) tests pass locally by running
docker-compose run --rm tests rspec
.Considerations
spec/integration/consumer_spec.rb
tests only passed when ran in isolation. I observed this on bothmaster
and my branch.Thanks in advance for your time! 🙇♀️