-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace lazy_static
with std::sync::LazyLock
#16066
Merged
maxdeviant
merged 9 commits into
zed-industries:main
from
SinanGncgl:remove-lazy-static
Aug 20, 2024
Merged
Replace lazy_static
with std::sync::LazyLock
#16066
maxdeviant
merged 9 commits into
zed-industries:main
from
SinanGncgl:remove-lazy-static
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e88baf0
to
137fd51
Compare
I think also once_cell crate can be replaced for example paradigmxyz/reth#9799 |
Yes, it can be a separate pr. |
lazy_static
with std::sync::LazyLock
maxdeviant
reviewed
Aug 12, 2024
5ab4e75
to
ac55aa2
Compare
maxdeviant
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15860
Since rust std now supports LazyLock replacing lazy_static with it reduce the external dependency.
Release Notes: