Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lazy_static with std::sync::LazyLock #16066

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

SinanGncgl
Copy link
Contributor

@SinanGncgl SinanGncgl commented Aug 10, 2024

Closes #15860

Since rust std now supports LazyLock replacing lazy_static with it reduce the external dependency.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 10, 2024
@kzhui125
Copy link

I think also once_cell crate can be replaced

for example paradigmxyz/reth#9799

@SinanGncgl
Copy link
Contributor Author

I think also once_cell crate can be replaced

for example paradigmxyz/reth#9799

Yes, it can be a separate pr.

@maxdeviant maxdeviant changed the title replace lazy_static with std::sync::LazyLock Replace lazy_static with std::sync::LazyLock Aug 12, 2024
@maxdeviant maxdeviant self-assigned this Aug 12, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant merged commit ff7017c into zed-industries:main Aug 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove lazy_static and use std::sync::LazyLock
3 participants