Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace once_cell with std::sync #9799

Closed
DaniPopes opened this issue Jul 25, 2024 · 5 comments · Fixed by #9844
Closed

Replace once_cell with std::sync #9799

DaniPopes opened this issue Jul 25, 2024 · 5 comments · Fixed by #9844
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Jul 25, 2024

Describe the feature

Replace once_cell::sync::Lazy with std::sync::LazyLock, which is now stable as of Rust 1.80

This requires also increasing MSRV to 1.80

Additional context

No response

@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Jul 25, 2024
@nkysg
Copy link
Contributor

nkysg commented Jul 25, 2024

May I take this?

@nkysg nkysg removed their assignment Jul 26, 2024
@tcoratger
Copy link
Contributor

@DaniPopes is it free? I've a pr ready if needed, let me know

@Rjected
Copy link
Member

Rjected commented Jul 26, 2024

@DaniPopes is it free? I've a pr ready if needed, let me know

no, @harsh-ps-2003 had one in progress that was already reviewed, and it was only closed due to git issues on their end, per the PR listed above. It would be best to wait for them to re-submit and give them a chance to go through the review process

@harsh-ps-2003
Copy link
Contributor

@Rjected @tcoratger thanks for waiting! Really appreciate it!

@tcoratger
Copy link
Contributor

@harsh-ps-2003 let me know if you need help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants