Refactor zarf destroy logic
#2275
Comments
5 tasks
Racer159
added a commit
that referenced
this issue
Jan 31, 2024
## Description This fixes ApplianceMode not being set and not triggering destroy scripts. ## Related Issue Fixes #2268 Relates to #2275 ## Type of change - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [X] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
daniel-palmer-gu
pushed a commit
to daniel-palmer-gu/zarf
that referenced
this issue
Feb 3, 2024
## Description This fixes ApplianceMode not being set and not triggering destroy scripts. ## Related Issue Fixes zarf-dev#2268 Relates to zarf-dev#2275 ## Type of change - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [X] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
Currently
zarf destroyuses bespoke logic that doesn't match up with howzarf package removefunctions. These two should be brought closer together so that both function similarly.Links to any relevant code
https://github.com/defenseunicorns/zarf/blob/main/src/cmd/destroy.go#L46
Additional context
This causes some of this logic to be poorly tested (Related to #2268)
The text was updated successfully, but these errors were encountered: