-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zarf destroy doesn't run zarf-clean-* scripts anymore #2268
Labels
bug 🐞
Something isn't working
Milestone
Comments
Just adding my thoughts when looking at cmd/destroy.go: |
This was referenced Jan 31, 2024
Racer159
added a commit
that referenced
this issue
Jan 31, 2024
## Description This fixes ApplianceMode not being set and not triggering destroy scripts. ## Related Issue Fixes #2268 Relates to #2275 ## Type of change - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [X] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
daniel-palmer-gu
pushed a commit
to daniel-palmer-gu/zarf
that referenced
this issue
Feb 3, 2024
## Description This fixes ApplianceMode not being set and not triggering destroy scripts. ## Related Issue Fixes zarf-dev#2268 Relates to zarf-dev#2275 ## Type of change - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [X] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Device and OS: linux/amd64
App version: 0.32.3
Kubernetes distro being used: k3s
Other:
Steps to reproduce
# zarf init --components k3s --confirm
# zarf destroy --confirm
Expected result
Expect the cluster to be torn down + /opt/zarf/zarf-clean-* scripts to be run
Actual Result
Tear down begins to take place, but the zarf-clean script is not run
Visual Proof (screenshots, videos, text, etc)
Begin install, command use:
[root@node1 test]# zarf init --components k3s --confirm
NOTE Saving log file to /tmp/zarf-2024-01-29-16-52-12-334353752.log
... snip standard zarf k3s install continues, removing for clarity...
📦 ZARF-AGENT COMPONENT
✔ Pushed 1 images to the zarf registry
✔ Starting helm chart generation zarf-agent
✔ Processing helm chart raw-init-zarf-agent-zarf-agent:0.1.1706565132 from Zarf-generated helm chart
✔ Wait for "./zarf tools wait-for pod app=agent-hook Ready -n zarf --..." succeeded
✔ Zarf deployment complete
[root@node1 test]# zarf destroy --confirm
NOTE Saving log file to /tmp/zarf-2024-01-29-17-00-04-622128922.log
✔ Waiting for cluster connection (30s timeout)
WARNING Unable to uninstall the chart
✔ Removing Zarf-installed charts
⠋ Deleting the zarf namespace from this cluster (6s)
✔ Removing zarf metadata & secrets from existing namespaces not managed by Zarf
[root@node1 test]#
Severity/Priority
Additional Context
Add any other context or screenshots about the technical debt here.
The text was updated successfully, but these errors were encountered: