Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ZNTA-2379) test button grommet component #717

Closed
wants to merge 2 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Feb 9, 2018

JIRA issue URL: https://zanata.atlassian.net/browse/ZNTA-2379

Task

  • test Grommet with Typescript (webpack build)
  • replace bootstrap button with grommet button on Languages page

Checklist

  • JIRA link
  • Check target branch
  • Make sure all commit statuses are green or otherwise documented reasons to ignore
  • QA needs to evaluate against the JIRA ticket
  • Changed files and commits make sense for this PR

See Zanata Development Guidelines more for information.


This template can be updated in .github/PULL_REQUEST_TEMPLATE.md


This change is Reviewable

@ghost ghost self-assigned this Feb 9, 2018
@ghost ghost added the Ignore CodeCov label Feb 9, 2018
@ghost ghost requested a review from alex-sl-eng February 9, 2018 03:42
@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #717 into master will increase coverage by 0.9%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #717     +/-   ##
===========================================
+ Coverage     33.54%   34.45%   +0.9%     
- Complexity     5781     5900    +119     
===========================================
  Files          1580     1604     +24     
  Lines         63183    67459   +4276     
  Branches       7362     8455   +1093     
===========================================
+ Hits          21197    23240   +2043     
- Misses        40052    42244   +2192     
- Partials       1934     1975     +41
Impacted Files Coverage Δ Complexity Δ
...ata-frontend/src/app/containers/Languages/index.js 8.16% <0%> (+8.16%) 0 <0> (ø) ⬇️
...-frontend/src/app/editor/components/Pager/index.js 58.33% <0%> (-18.14%) 0% <0%> (ø)
...end/src/app/editor/reducers/header-data-reducer.js 90.9% <0%> (-9.1%) 0% <0%> (ø)
...erver/zanata-frontend/src/app/utils/StringUtils.js 37.5% <0%> (-6.95%) 0% <0%> (ø)
.../zanata-frontend/src/app/reducers/admin-reducer.js 83.33% <0%> (-4.55%) 0% <0%> (ø)
...ata-frontend/src/app/editor/reducers/ui-reducer.js 84.48% <0%> (-3.4%) 0% <0%> (ø)
...rc/app/editor/components/ActivityFeedItem/index.js 89.28% <0%> (-2.15%) 0% <0%> (ø)
...a/webtrans/server/rpc/AddReviewCommentHandler.java 96.07% <0%> (-1.29%) 14% <0%> (+4%)
...nd/src/app/editor/reducers/phrase-reducer/index.js 97.26% <0%> (-0.46%) 0% <0%> (ø)
...in/java/org/zanata/security/SecurityFunctions.java 3.57% <0%> (-0.28%) 9% <0%> (+4%)
... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6491d3a...279114e. Read the comment docs.

@ghost ghost removed the Awaiting review label Feb 16, 2018
@ghost ghost closed this Feb 16, 2018
@ghost ghost added Work in progress and removed DO NOT MERGE labels Mar 12, 2018
@ghost ghost reopened this Mar 12, 2018
@ghost ghost closed this Mar 12, 2018
@ghost
Copy link
Author

ghost commented Mar 12, 2018

Reopened as #748

@ghost ghost deleted the ZNTA2379 branch March 12, 2018 22:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants