Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZNTA-2379: test Grommet with Typescript (webpack build) #714

Closed
wants to merge 65 commits into from
Closed

ZNTA-2379: test Grommet with Typescript (webpack build) #714

wants to merge 65 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 5, 2018 •
edited by ghost
Loading

JIRA issue URL: https://zanata.atlassian.net/browse/ZNTA-2379

Checklist

  • JIRA link
  • Check target branch
  • Make sure all commit statuses are green or otherwise documented reasons to ignore
  • QA needs to evaluate against the JIRA ticket
  • Changed files and commits make sense for this PR

See Zanata Development Guidelines more for information.

This template can be updated in .github/PULL_REQUEST_TEMPLATE.md

This change is Reviewable

seanf added 30 commits January 22, 2018 14:31
@seanf
Add more @types
602f55c
@seanf
Tweak JSDoc comments to suit TS
f840b08
@seanf
eslint: disable line limits for JSX
b364f74
@seanf
Add typescript dependency
867acfd
@seanf
Add basic TypeScript config
53f9954
@seanf
Add extract-messages script
4408b61
@seanf
Use tslib and --importHelpers
63e6ef1
@seanf
Add a tsx file and use ts-check in js
8fb78dc
@seanf
Fix TextDiff imports
e58dfcf
@seanf
Configure vscode to use local TypeScript
876ffc8
@seanf
Add lots of @types
69c5859
@seanf
Move @types/chart.js to devDependencies
0322811
@seanf
Remove babel, add typescript loader
e8188a0
@seanf
Run tests with ts-jest
11047b1
@seanf
wip
16c851c
@seanf
fix eslint
56caf9a
@seanf
wip imports
1ae6806
@seanf
temp: disable enLocaleData
be429ca
@seanf
Remove @types/react-split-pane
2502408
@seanf
Fix some imports
264ed20
@seanf
Upgrade to TypeScript 2.7rc
3fdeedb
@seanf
Revert require isomorphic-fetch
04c9190
@seanf
Add timestamp to watch builds
169da1e
@seanf
Revert some import changes
ae5c9b5
@seanf
Revert React import (proptypes warning)
7a21380
@seanf
Allow at-loader to use cache
f41a5f3
@seanf
Allow at-loader to use async error reporting
cc6aeb7
@seanf
Use eval-source-map for dev
0b86960
@seanf
Add TypeScript types to some files
b9bcd7f
@seanf
Merge remote-tracking branch 'origin/master' into typescript3
b6881a2
@ghost ghost added the Work in progress label Feb 5, 2018
@ghost ghost self-assigned this Feb 5, 2018
@ghost ghost requested review from davidmason and removed request for davidmason February 5, 2018 12:00
@alex-sl-eng
Copy link
Member

@kathryngo I think you might want to rebase or merge master into this branch.

@ghost ghost changed the title ZNTA-2379: test Grommet with Typescript (webpack sass build) ZNTA-2379: test Grommet with Typescript (webpack build) Feb 8, 2018
@ghost ghost closed this Feb 9, 2018
@ghost ghost deleted the ZNTA-2379 branch February 9, 2018 03:05
@ghost ghost removed the Work in progress label Feb 9, 2018
@ghost
Copy link
Author

ghost commented Feb 9, 2018

broken build on this branch. made changes to another (#717) that was built from a clean copy of master

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-sl-eng @seanf