Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

RBAC for automatic legacy peering detection #95

Merged
merged 3 commits into from
Jun 14, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Jun 2, 2019

Issue : #12, #13, originally mentioned in #49 comments

Add the missing RBAC permissions for legacy CRD scanning in the documentation (deployment patterns, RBAC section).

Since CRD scanning is a cluster-scoped operation, and cluster-scoped RBAC is not always possible, make so that the "403 permission denied" response for CRDs is treated as the absence of CRD. It is currently only used for legacy peering CRD, and nothing else.

As part of that, in tests, also check for other typical statuses for all get/list API operations — via parametrization.

PS: The feature was introduced in the automatic peering/standalone mode discovery (#33 #38).

@nolar nolar added documentation Documentation improvements automation CI/CD: testing, linting, releasing automatically labels Jun 2, 2019
@nolar nolar requested a review from samurang87 as a code owner June 2, 2019 03:17
@zincr
Copy link

zincr bot commented Jun 2, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Jun 2, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

1 similar comment
@zincr
Copy link

zincr bot commented Jun 2, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar changed the title Rbac for autopeering RBAC for automatic legacy peering detection Jun 2, 2019
@nolar nolar merged commit 3a127e5 into zalando-incubator:master Jun 14, 2019
@nolar nolar deleted the rbac-for-autopeering branch June 14, 2019 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically documentation Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants