This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
RBAC for automatic legacy peering detection #95
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing RBAC permissions for legacy CRD scanning in the documentation (deployment patterns, RBAC section).
Since CRD scanning is a cluster-scoped operation, and cluster-scoped RBAC is not always possible, make so that the "403 permission denied" response for CRDs is treated as the absence of CRD. It is currently only used for legacy peering CRD, and nothing else.
As part of that, in tests, also check for other typical statuses for all get/list API operations — via parametrization.
PS: The feature was introduced in the automatic peering/standalone mode discovery (#33 #38).