-
Notifications
You must be signed in to change notification settings - Fork 87
[GH-33] implement auto detection mode for peering. #38
[GH-33] implement auto detection mode for peering. #38
Conversation
🤖 zincr found 0 problems , 0 warnings
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psycho-ir Great work! Thanks. This should do the trick — I will try it out a bit later today.
There is only one important change request on the main()
invocation. The rest are just the suggestions — for you to decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried it locally. There is a little bug with the ...cls(peering=None,...
— crashes on start (see comments). Once fixed, it works nice in all modes, exactly as intended.
Would you like to extend the docs (docs/peering.rst
→ https://kopf.readthedocs.io/en/latest/peering/) in this PR? Or I can do this in the following PRs, together with other peering doc changes.
@psycho-ir PS: Also, feel free to remove the clutter from the PR body if you want. (I think, the PR template must be reduced to only an issue reference (it is mandatory), with no implicit structure. — Will do later.) |
Co-Authored-By: psycho-ir <[email protected]>
Sure, I will extend the docs tomorrow and try to add some tests for it. |
@@ -11,9 +11,10 @@ The operator can be instructed to use alternative peering objects:: | |||
|
|||
The operators from different peering objects do not see each other. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nolar I updated the peering doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psycho-ir Thanks.
kopf/reactor/peering.py
Outdated
if Peer._is_default_peering_setup(): | ||
return cls(peering=PEERING_DEFAULT_NAME, **kwargs) | ||
|
||
logger.warning(f"The default peering object not found. Falling back to the Standalone mode...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'* Default peering object not found, falling back to Standalone mode
@psycho-ir So, it is merged and released as |
@nolar yaaaaaay. what is the next milestone? Would be happy to contribute more in this project. |
Currently, the milestone 1 is this:
Since then, the framework is sufficiently feature-rich for the first stage (it is now, actually, just the docs do not feel complete), and can be advertised in public: meetups, blog posts, so on. Based on the real-world feedback, the next milestones can be defined. The real-world usage is the most important goal now. I.e., getting the operators implemented with this framework (and preferably shared). Meanwhile, I write down all the ideas that come to my mind as the issues. If you have some suggestions, feel free to create the issues too. Examples: #44, #45, #46. |
@nolar I will write the tests and document it once we agreed on the implementation.