Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Use the core v1 API instead of v1beta1, for GKE>=1.12 compatibility #81

Merged
merged 2 commits into from
May 28, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented May 28, 2019

Issue : #76

Starting from GKE 1.12 (Google Kubernetes Engine), the legacy APIs are disabled by default — disable-legacy-endpoints=true is added on the cluster creation. Official doc.

As such, events of v1beta1 are not accessible, and Kopf fails on the simple examples (see #76). v1 events should be used instead.

This PR switches to the v1 events. And v1beta1 are now disabled for Minikube, so it will fails if accidentally used. Also, it adds the unit-tests that were absent since #71 .

Beside the tests, I have manually tested the Kopf example operator to run in GKE — now, it works (before the fix, it was failing on the event posting).

@nolar nolar requested a review from samurang87 as a code owner May 28, 2019 14:19
@nolar nolar added the bug Something isn't working label May 28, 2019
@nolar nolar added this to the 1.0 milestone May 28, 2019
@zincr
Copy link

zincr bot commented May 28, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@nolar nolar merged commit 813cf83 into zalando-incubator:master May 28, 2019
@nolar nolar deleted the 76-gke-legacy-endpoints branch May 28, 2019 14:42
@smileisak
Copy link
Contributor

I was working on it. I did not see the issue 👍. Nice work !

@nolar
Copy link
Contributor Author

nolar commented May 28, 2019

@smileisak Oops. Sorry.

Since contributors started to join, I think, we should start syncing the allocation of issues by assigning them. I've self-assigned those I work on right now. Feel free to choose a free one: https://github.com/zalando-incubator/kopf/issues (or create a new one if the bug/enhancement is not mentioned yet).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants