This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Use the core v1 API instead of v1beta1, for GKE>=1.12 compatibility #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from GKE 1.12 (Google Kubernetes Engine), the legacy APIs are disabled by default —
disable-legacy-endpoints=true
is added on the cluster creation. Official doc.As such, events of
v1beta1
are not accessible, and Kopf fails on the simple examples (see #76).v1
events should be used instead.This PR switches to the
v1
events. And v1beta1 are now disabled for Minikube, so it will fails if accidentally used. Also, it adds the unit-tests that were absent since #71 .Beside the tests, I have manually tested the Kopf example operator to run in GKE — now, it works (before the fix, it was failing on the event posting).