You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Starting from GKE 1.12 (Google Kubernetes Engine), the legacy APIs are disabled by default — disable-legacy-endpoints=true is added on the cluster creation. Official doc.
As such, events of v1beta1 are not accessible, and Kopf fails on the simple examples (see #76). v1 events should be used instead.
This PR switches to the v1 events. And v1beta1 are now disabled for Minikube, so it will fails if accidentally used. Also, it adds the unit-tests that were absent since #71 .
Beside the tests, I have manually tested the Kopf example operator to run in GKE — now, it works (before the fix, it was failing on the event posting).
Commented by smileisak at 2019-05-28 14:48:31+00:00
I was working on it. I did not see the issue 👍. Nice work !
Since contributors started to join, I think, we should start syncing the allocation of issues by assigning them. I've self-assigned those I work on right now. Feel free to choose a free one: https://github.com/nolar/kopf/issues (or create a new one if the bug/enhancement is not mentioned yet).
The text was updated successfully, but these errors were encountered:
Starting from GKE 1.12 (Google Kubernetes Engine), the legacy APIs are disabled by default —
disable-legacy-endpoints=true
is added on the cluster creation. Official doc.As such, events of
v1beta1
are not accessible, and Kopf fails on the simple examples (see #76).v1
events should be used instead.This PR switches to the
v1
events. And v1beta1 are now disabled for Minikube, so it will fails if accidentally used. Also, it adds the unit-tests that were absent since #71 .Beside the tests, I have manually tested the Kopf example operator to run in GKE — now, it works (before the fix, it was failing on the event posting).
I was working on it. I did not see the issue 👍. Nice work !
smileisak Oops. Sorry.
Since contributors started to join, I think, we should start syncing the allocation of issues by assigning them. I've self-assigned those I work on right now. Feel free to choose a free one: https://github.com/nolar/kopf/issues (or create a new one if the bug/enhancement is not mentioned yet).
The text was updated successfully, but these errors were encountered: