Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Use the core v1 API instead of v1beta1, for GKE>=1.12 compatibility #81

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
Labels
archive bug Something isn't working

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-05-28 14:19:01+00:00
Original URL: zalando-incubator/kopf#81
Merged by nolar at 2019-05-28 14:42:07+00:00

Issue : #76

Starting from GKE 1.12 (Google Kubernetes Engine), the legacy APIs are disabled by default — disable-legacy-endpoints=true is added on the cluster creation. Official doc.

As such, events of v1beta1 are not accessible, and Kopf fails on the simple examples (see #76). v1 events should be used instead.

This PR switches to the v1 events. And v1beta1 are now disabled for Minikube, so it will fails if accidentally used. Also, it adds the unit-tests that were absent since #71 .

Beside the tests, I have manually tested the Kopf example operator to run in GKE — now, it works (before the fix, it was failing on the event posting).


Commented by smileisak at 2019-05-28 14:48:31+00:00
 

I was working on it. I did not see the issue 👍. Nice work !


Commented by nolar at 2019-05-28 15:21:53+00:00
 

smileisak Oops. Sorry.

Since contributors started to join, I think, we should start syncing the allocation of issues by assigning them. I've self-assigned those I work on right now. Feel free to choose a free one: https://github.com/nolar/kopf/issues (or create a new one if the bug/enhancement is not mentioned yet).

@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Use the core v1 API instead of v1beta1, for GKE>=1.12 compatibility Aug 19, 2020
@kopf-archiver kopf-archiver bot added the bug Something isn't working label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants