This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
[269] Fix broken CI/CD tests due to Minikube w/ K8s 1.17.0 + RBAC #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minikube is broken with K8s 1.17.0+RBAC. The related Minikube issue is linked in #269.
Authorization is changed from "RBAC" to "Node,RBAC". This PR will allow us to continue with the development.
Originally, RBAC-only mode was enabled to ensure that the operators are runnable in our RBAC-only environment, and the default Kubernetes authorization mode "Node,RBAC" was false-positive in some cases (back then in ~Apr'2019), so the issues were noticed only during the deployments to a RBAC-only environment.
By disabling this mode, we can get those false-positive test results again (RBAC-related). But this is the only way to make it run in CI/CD.
PS: "False-positives" in this cases means that something can be actually broken for the RBAC-only environment, but the tests do not detect this due to "Node,RBAC" mode, and report the successes.
Types of Changes