Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

[269] Fix broken CI/CD tests due to Minikube w/ K8s 1.17.0 + RBAC #270

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Dec 12, 2019

Issue : #269

Description

Minikube is broken with K8s 1.17.0+RBAC. The related Minikube issue is linked in #269.

Authorization is changed from "RBAC" to "Node,RBAC". This PR will allow us to continue with the development.

Originally, RBAC-only mode was enabled to ensure that the operators are runnable in our RBAC-only environment, and the default Kubernetes authorization mode "Node,RBAC" was false-positive in some cases (back then in ~Apr'2019), so the issues were noticed only during the deployments to a RBAC-only environment.

By disabling this mode, we can get those false-positive test results again (RBAC-related). But this is the only way to make it run in CI/CD.

PS: "False-positives" in this cases means that something can be actually broken for the RBAC-only environment, but the tests do not detect this due to "Node,RBAC" mode, and report the successes.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Configuration change

@nolar nolar added bug Something isn't working automation CI/CD: testing, linting, releasing automatically labels Dec 12, 2019
@nolar nolar requested a review from samurang87 as a code owner December 12, 2019 12:22
@zincr
Copy link

zincr bot commented Dec 12, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Dec 12, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

1 similar comment
@zincr
Copy link

zincr bot commented Dec 12, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar merged commit 9f5d940 into zalando-incubator:master Dec 12, 2019
@nolar nolar deleted the 269-minikube-rbac branch December 12, 2019 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants