Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] [269] Fix broken CI/CD tests due to Minikube w/ K8s 1.17.0 + RBAC #270

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed
Labels
archive automation CI/CD: testing, linting, releasing automatically bug Something isn't working

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-12-12 12:22:47+00:00
Original URL: zalando-incubator/kopf#270
Merged by nolar at 2019-12-12 13:00:16+00:00

Issue : #269

Description

Minikube is broken with K8s 1.17.0+RBAC. The related Minikube issue is linked in #269.

Authorization is changed from "RBAC" to "Node,RBAC". This PR will allow us to continue with the development.

Originally, RBAC-only mode was enabled to ensure that the operators are runnable in our RBAC-only environment, and the default Kubernetes authorization mode "Node,RBAC" was false-positive in some cases (back then in ~Apr'2019), so the issues were noticed only during the deployments to a RBAC-only environment.

By disabling this mode, we can get those false-positive test results again (RBAC-related). But this is the only way to make it run in CI/CD.

PS: "False-positives" in this cases means that something can be actually broken for the RBAC-only environment, but the tests do not detect this due to "Node,RBAC" mode, and report the successes.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Configuration change
@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] [269] Fix broken CI/CD tests due to Minikube w/ K8s 1.17.0 + RBAC Aug 19, 2020
@kopf-archiver kopf-archiver bot added automation CI/CD: testing, linting, releasing automatically bug Something isn't working labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive automation CI/CD: testing, linting, releasing automatically bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants