fix: update @graphql-typed-document-node/core for graphql@16 support #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might explains I few of the problems I hit, good spot @SimenB! |
oporkka
reviewed
Feb 4, 2022
| @@ -81,7 +81,7 @@ | |||
| "typescript": "^4.4.4" | |||
| }, | |||
| "dependencies": { | |||
| "@graphql-typed-document-node/core": "3.1.0", | |||
There was a problem hiding this comment.
yeah, ideally it'd just be ^3.1.0 I guess 🙂
|
@SimenB please run also |
|
Sorry for accidental close |
oporkka
reviewed
Feb 4, 2022
Co-authored-by: Oskari Porkka <[email protected]>
This was referenced Feb 4, 2022
|
👍 |
1 similar comment
|
👍 |
|
Thanks! Could you release this as well? 😀 |
|
@SimenB going out now, thanks for the contribution. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why the version is locked down, but 3.1.0 does not have
graphql@16in its peer dependency range