-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypedDocumentNode support #139
Add TypedDocumentNode support #139
Conversation
Is there anything I can do to get this merged? |
We have to get two Zalando employees to review this PR. As the reviewers might not be familiar with |
Sure. GraphQL-Codegen generates a ready-to-use
This way, developers don't need to specify types manually at all. |
@ardatan please run the formatter. This PR lgtm! |
I think it is good now! @ruiaraujo |
👍 |
@ardatan i believe you are pushing code to the wrong branch. |
77d4bb3
to
937a4d9
Compare
@ruiaraujo Yes I realized that :) I cherrypicked those commits to the other PR |
Ok I fixed lint/format issue because of the new import. |
👍 |
I think it is ready to merge right? @ruiaraujo |
Once a colleague from zalando approves, it will be merged. |
@boopathi Could you review please? :) |
👍 |
Thank you for this great library!
This PR adds
TypedDocumentNode
support tographql-jit
. For example, generatedTypedDocumentNode
queries will have type safe signature withgraphql-jit
.It also enables to use generics in
CompiledQuery
to have better type safety.https://github.com/dotansimha/graphql-typed-document-node