BREAKING: Add ContentPages and Invoke(sender) #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
the
Area-API
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
…and-invokes # Conflicts: # src/modules/cmdpal/Microsoft.CmdPal.UI/Microsoft.CmdPal.UI.csproj
zadjii-msft
added a commit
that referenced
this pull request
Feb 20, 2025
Well, I started by wanting to just close #385. Then I thought, "well, the copy command really needs that toast, doesn't it" one thing lead to another, and now  Closes #385 Closes # what I never filed `ShowToast`, from #395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING API CHANGES APPROACHING
Closes #307
Closes #238
Removes
CommandfromITagAdds
IDetailsCommand(to achieve the same goal as the above originally had)Adds
ITreeContent, based on a hunchAdds
ShowToastandConfirmtoCommandResulttoo, but without UX yetExtensions from before this change will need to be updated.
InvokableCommandchange should be trivial - the helpers should abstract that delta away for you.ContentPagechange should be pretty easy to make.MarkdownPageandFormPageare now justContentPageFormPage.Forms()->ContentPage.GetContent()MarkdownPage.Bodies()->ContentPage.GetContent()IForms becomeIFormContent. Methods become properties (not that bad)Tag.Commandand it always seemed iffy at best - better not.