-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the confirmation dialog for CommandResult.Confirm
#399
Comments
I've investigated some possible implement, and I think we need to discuss some API design for this usage. Just a example, please consider we need to do a dangerous operator, such as shut down the computer. So, if our design is, return a CommandResult.Confirm, what's the next step? Where should we get the result and continue to process? I make a simple demo to show my implement. I set up the dialog configuration and the callback function, then pass it to the host. Host will create a new window and show the dialog on this new window (not cmdpal), receive user's selection and use it to call the callback function. @zadjii-msft any suggestion? content-dialog.mp4 |
@moooyo is there any reason we can't just open that |
Oh...My bad, we can do. I was trapped in the contentDialog API itself before. We can do it sure. I will try to implement it on the main page. @zadjii-msft |
How about this one? @zadjii-msft Video.Project.7.mp4Code here: #536 |
That's like exactly what I pictured! |
as spec'd in #395
we need a dialog to prompt for confirmation of certain destructive commands.
The text was updated successfully, but these errors were encountered: