Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix + add rank + animation for bonuses #52

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Fix + add rank + animation for bonuses #52

merged 9 commits into from
Oct 18, 2024

Conversation

Matth26
Copy link
Contributor

@Matth26 Matth26 commented Oct 18, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced custom hooks: useGamesFromTournament for managing tournament games and useRank for calculating player ranks.
    • Added BonusAnimation component to display animated bonus notifications during gameplay.
    • Enhanced GameBoard to include tournament features and bonus animations.
  • Improvements

    • Updated dialog management in the Create component for better interactivity.
    • Enhanced button styles to improve visual feedback during loading states.
  • Bug Fixes

    • Adjusted conditional logic in the Wave class to improve game mechanics related to combo counts.
  • Chores

    • Updated several configuration files with new deployment details and hashes.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zkube-dev ❌ Failed (Inspect) Oct 18, 2024 6:01pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
zkube ⬜️ Ignored (Inspect) Oct 18, 2024 6:01pm

Copy link

coderabbitai bot commented Oct 18, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several changes across various files, primarily focusing on game mechanics, UI components, and configuration files. Key modifications include adjustments to the Wave class's getCount method to increase combo thresholds, the addition of new hooks for managing tournament games and player ranks, and enhancements to UI components like GameBoard and Create. Configuration files for contracts have also been updated to reflect new deployment details, including address and class hash changes.

Changes

File Path Change Summary
client/src/dojo/game/elements/bonuses/wave.ts Updated getCount method in Wave class to increase combo thresholds for returning counts.
client/src/hooks/useGame.tsx Removed commented-out console log statement in useGame hook.
client/src/hooks/useGamesFromTournament.tsx Added new hook useGamesFromTournament for managing games in a tournament.
client/src/hooks/useRank.tsx Introduced new hook useRank for calculating player rank and ordinal suffix.
client/src/ui/actions/Create.tsx Added state variable open for dialog management and modified button text for player creation.
client/src/ui/components/Block.tsx Updated BlockProps interface to include optional gridHeight property.
client/src/ui/components/BonusAnimation.tsx Added new BonusAnimation component for displaying animated bonus notifications.
client/src/ui/components/GameBoard.tsx Modified GameBoard to include new props and integrate BonusAnimation and tournament features.
client/src/ui/components/Grid.tsx Added state variable nextLine for managing blocks and updated drag event handling.
client/src/ui/elements/button.tsx Updated button styles for the disabled state and added loading state logic.
client/src/ui/screens/Home.tsx Hardcoded isSigning variable and updated GameBoard component props.
contracts/dojo_sepolia.toml Updated seed value and commented out cover_uri and icon_uri.
contracts/dojo_slotdev.toml Updated seed value and commented out cover_uri and icon_uri.
contracts/manifests/sepolia/base/contracts/zkube-play-19ee70b3.toml Updated class_hash and original_class_hash values.
contracts/manifests/sepolia/deployment/manifest.json Updated address, transaction_hash, and seed in world, along with multiple contract addresses.
contracts/manifests/sepolia/deployment/manifest.toml Updated contract addresses, transaction hashes, seeds, and class hashes for various entities.
contracts/manifests/slotdev/base/contracts/zkube-play-19ee70b3.toml Updated class_hash and original_class_hash values.
contracts/manifests/slotdev/deployment/manifest.json Updated world and base sections, along with contract addresses and hashes.

Possibly related PRs

  • Add difficulty (TB tested) #10: Changes in the Game class related to difficulty levels may connect with the Wave class's getCount method, as both involve game mechanics and scoring logic.
  • Bonuses #13: Modifications to the GameBoard component and the introduction of bonus handling are relevant, as they may interact with the Wave class's logic for determining bonus counts based on combos.
  • updated the start component #28: Updates to the Start component and its props may relate to the overall game state management, which could include interactions with the Wave class's scoring logic.
  • Updated leaderboard #29: Leaderboard updates that include potential winnings and buy-in amounts may connect with the scoring and bonus logic in the Wave class, as both deal with game outcomes.
  • Add optimistic + loading + few fixes for mobile + multipliers #49: Introduction of multipliers and their calculations in the Game class may directly relate to the scoring logic in the Wave class, as both involve game mechanics that affect player performance and rewards.

🐰 In the land of the game, where combos grow tall,
The Wave class now counts, with thresholds for all.
New hooks for the tournaments, ranks to define,
With animations of bonuses, oh how they shine!
So hop with delight, let the players engage,
For every new change, brings a fresh page! 🎮✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Matth26 Matth26 merged commit 89f2642 into main Oct 18, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants