Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix + add rank + animation for bonuses #51

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Conversation

Matth26
Copy link
Contributor

@Matth26 Matth26 commented Oct 18, 2024

Summary by CodeRabbit

  • New Features

    • Introduced custom hooks useGamesFromTournament and useRank for managing tournament games and player rankings.
    • Added BonusAnimation component for animated bonus notifications during gameplay.
    • Enhanced GameBoard component with tournament features and improved game state handling.
  • Bug Fixes

    • Adjusted logic in the Wave class to modify combo thresholds for bonus counts.
  • Style

    • Updated button styles for better visual feedback on disabled state.
    • Improved rendering logic in various components for better user experience.
  • Chores

    • Updated configuration files and deployment manifests to reflect new contract addresses and transaction hashes.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zkube-dev ❌ Failed (Inspect) Oct 18, 2024 5:56pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
zkube ⬜️ Ignored (Inspect) Oct 18, 2024 5:56pm

Copy link

coderabbitai bot commented Oct 18, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on updates to the logic for determining bonus counts based on combo thresholds in the Wave class and its Cairo counterpart. Additionally, new React hooks for managing tournament games and player ranks are added, while existing components are modified to enhance functionality and state management. Configuration files are updated to reflect new deployment parameters, including changes to seed values and contract addresses.

Changes

File Path Change Summary
client/src/dojo/game/elements/bonuses/wave.ts Updated getCount method thresholds for combo values: 8 to 16, 16 to 32, 24 to 64.
contracts/src/elements/bonuses/wave.cairo Updated get_count function thresholds for combo_count: 8 to 16, 16 to 32, 24 to 64.
client/src/hooks/useGame.tsx Removed commented-out console log statement; logic for obtaining gameKey and game unchanged.
client/src/hooks/useGamesFromTournament.tsx Introduced useGamesFromTournament hook to manage games for a specific tournament.
client/src/hooks/useRank.tsx Introduced useRank hook to calculate player rank and ordinal suffix based on tournament games.
client/src/ui/actions/Create.tsx Added state variable open for dialog management; modified button text for consistency.
client/src/ui/components/Block.tsx Added optional gridHeight property to BlockProps interface; updated rendering logic based on gridHeight.
client/src/ui/components/BonusAnimation.tsx Introduced BonusAnimation component for displaying animated bonus notifications.
client/src/ui/components/GameBoard.tsx Updated to include game prop; modified logic for tournament information display.
client/src/ui/components/Grid.tsx Added nextLine state variable; adjusted drag handling logic and rendering logic.
client/src/ui/elements/button.tsx Updated button styles for disabled state and modified loading spinner display logic.
client/src/ui/screens/Home.tsx Hardcoded isSigning to false; updated GameBoard component to include game prop.
contracts/dojo_sepolia.toml Updated seed value from "zKube11" to "zKube12"; commented out cover_uri and icon_uri.
contracts/dojo_slotdev.toml Updated seed value from "zKube10" to "zKube11"; commented out cover_uri and icon_uri.
contracts/manifests/sepolia/base/contracts/zkube-play-19ee70b3.toml Updated class_hash and original_class_hash values.
contracts/manifests/sepolia/deployment/manifest.json Updated contract addresses, transaction hashes, and seed values reflecting new deployment state.
contracts/manifests/sepolia/deployment/manifest.toml Updated addresses, transaction hashes, block numbers, seeds, and class hashes for various contracts and models.
contracts/manifests/slotdev/base/contracts/zkube-play-19ee70b3.toml Updated class_hash and original_class_hash values.
contracts/manifests/slotdev/deployment/manifest.json Updated contract addresses, transaction hashes, block numbers, and seed values reflecting new deployment state.
contracts/manifests/slotdev/deployment/manifest.toml Updated addresses, transaction hashes, seeds, and class hashes for various contracts and models.

Possibly related PRs

  • Bonuses #13: The changes in this PR involve modifications to the getCount method in the Wave class, which are directly related to the adjustments made in the get_count function in the contracts/src/elements/bonuses/wave.cairo file, as both PRs update the thresholds for returning values based on the combo parameter.

🐇 In the land of code so bright,
Waves of change take flight,
Combos rise, thresholds soar,
New hooks and features galore!
With buttons styled and games in play,
Let’s hop along and code away! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Matth26 Matth26 merged commit e3ffed9 into dev Oct 18, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants