Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notes indicating that the benchmark binaries are compiled with… #4068

Merged
merged 2 commits into from
Mar 28, 2020
Merged

Adding notes indicating that the benchmark binaries are compiled with… #4068

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d26ebd0
Adding notes indicating that the benchmark binaries are compiled with…
Mar 25, 2020
6eda31f
Addressed comments.
Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/content/latest/benchmark/tpcc-ysql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ $ tar -zxvf tpcc.tar.gz
$ cd tpcc
```

{{< note title="Note" >}}
The binaries are compiled with JAVA 13.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe be a bit more explicit? Say:

It is recommended to run these binaries with Java 13. Note that this package currently does not work with Java 14.

Also, would something compiled with Java 14 work with Java 13? If so we should just upload newer binaries and remove this note later.

{{< /note >}}

## Step 2. Start your database

Start the database using the steps mentioned [here](https://docs.yugabyte.com/latest/quick-start/create-local-cluster/macos/).
Expand Down
4 changes: 4 additions & 0 deletions docs/content/latest/benchmark/ycsb-ycql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ $ tar -zxvf ycsb.tar.gz
$ cd YCSB
```

{{< note title="Note" >}}
The binaries are compiled with JAVA 13.
{{< /note >}}

## Step 2. Start YugabyteDB

Start your YugabyteDB cluster by following the steps in [Quick start](https://docs.yugabyte.com/latest/quick-start/explore-ysql/).
Expand Down
4 changes: 4 additions & 0 deletions docs/content/latest/benchmark/ycsb-ysql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ $ tar -zxvf ycsb.tar.gz
$ cd YCSB
```

{{< note title="Note" >}}
The binaries are compiled with JAVA 13.
{{< /note >}}

## Step 2. Start YugabyteDB

Start your YugabyteDB cluster by following the steps in [Quick start](https://docs.yugabyte.com/latest/quick-start/explore-ysql/).
Expand Down