Adding notes indicating that the benchmark binaries are compiled with… #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JAVA 13 Reviewers: Neha
|
sudheer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Can one of the admins verify this patch? |
rkarthik007
approved these changes
Mar 25, 2020
| @@ -39,6 +39,10 @@ $ tar -zxvf tpcc.tar.gz | |||
| $ cd tpcc | |||
| ``` | |||
|
|
|||
| {{< note title="Note" >}} | |||
| The binaries are compiled with JAVA 13. | |||
There was a problem hiding this comment.
Maybe be a bit more explicit? Say:
It is recommended to run these binaries with Java 13. Note that this package currently does not work with Java 14.
Also, would something compiled with Java 14 work with Java 13? If so we should just upload newer binaries and remove this note later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… JAVA 13
Reviewers: Neha