Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky connection metrics are not available on prometheus endpoint #25775

Open
yugabyte-ci opened this issue Jan 28, 2025 · 0 comments
Open

Sticky connection metrics are not available on prometheus endpoint #25775

yugabyte-ci opened this issue Jan 28, 2025 · 0 comments
Assignees
Labels
jira-originated kind/bug This issue is a bug priority/high High Priority

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Jan 28, 2025

Jira Link: DB-15041

@yugabyte-ci yugabyte-ci added jira-originated kind/bug This issue is a bug priority/high High Priority labels Jan 28, 2025
rahulb-yb added a commit that referenced this issue Jan 31, 2025
Summary:
Sticky connections were introduced as a new metric in D40484, but were left out from being published to the prometheus endpoint. This patch pushes the same information to the prometheus-metrics endpoint in addition to the pre-existing connections endpoint.

Jira: DB-15041

Test Plan:
Jenkins: enable connection manager, all tests

Verify that sticky conn metrics are available on prometheus endpoint on a local cluster

Reviewers: skumar, mkumar, devansh.saxena, vpatibandla

Reviewed By: mkumar, devansh.saxena

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D41484
rahulb-yb added a commit that referenced this issue Jan 31, 2025
… endpoint

Summary:
Sticky connections were introduced as a new metric in D40484, but were left out from being published to the prometheus endpoint. This patch pushes the same information to the prometheus-metrics endpoint in addition to the pre-existing connections endpoint.

Jira: DB-15041

Original commit: 6750c49 / D41484

**Merge conflicts**
On master, the file `src/yb/yql/pggate/webserver/pgsql_webserver_wrapper.cc` was renamed to `src/yb/yql/pggate/webserver/ybc_pg_webserver_wrapper.cc`. This change is not present on 2024.2 leading to some merge conflicts - just had to patch the same changes on the appropriate file for this back port diff

Test Plan:
Jenkins: enable connection manager, all tests

Verify that sticky conn metrics are available on prometheus endpoint on a local cluster

Reviewers: skumar, mkumar, devansh.saxena, vpatibandla

Reviewed By: skumar

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D41546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira-originated kind/bug This issue is a bug priority/high High Priority
Projects
None yet
Development

No branches or pull requests

2 participants