Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add pre-commit hooks for linting and formatting #99

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

rickstaa
Copy link
Collaborator

@rickstaa rickstaa commented Feb 27, 2025

This pull request introduces pre-commit hooks using Husky, lint-staged, ESLint,and Prettier to ensure code quality and consistency. The hooks automaticallylint and format code before each commit, covering JavaScript, TypeScript, CSS, and Markdown files.

@rickstaa rickstaa force-pushed the add_pre_commit_hook branch 2 times, most recently from b564c25 to d262e2c Compare February 27, 2025 09:30
@rickstaa rickstaa changed the title add pre commit hook chore(ui): add pre-commit hooks for linting and formatting Feb 27, 2025
@rickstaa rickstaa force-pushed the add_pre_commit_hook branch from d262e2c to f24c2fa Compare February 27, 2025 09:35
@hjpotter92
Copy link
Collaborator

we can add a github workflow to run a few of these lint/coverage/etc tests on github CI as well.

@rickstaa
Copy link
Collaborator Author

we can add a github workflow to run a few of these lint/coverage/etc tests on github CI as well.

It would be great to prevent people from using --no-verify and accidentally pushing incorrect code. I've added a pre-commit hook now, so that developers don't have to wait for CI to catch errors later.

@eliteprox
Copy link
Collaborator

@rickstaa Is this ready to review/merge? We can use the linter in some upcoming PRs

This commit introduces pre-commit hooks using Husky, lint-staged, ESLint,
and Prettier to ensure code quality and consistency. The hooks automatically
lint and format code before each commit, covering JavaScript, TypeScript, CSS,
and Markdown files.
This commit applies the Prettier formatter to the codebase to ensure
consistent code style and formatting.
Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging to unblock #98

@eliteprox eliteprox merged commit 9f8cf3a into yondonfu:main Feb 28, 2025
@rickstaa rickstaa deleted the add_pre_commit_hook branch February 28, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants