Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Add workflow for generating static assets for release #98

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

hjpotter92
Copy link
Collaborator

No description provided.

@rickstaa
Copy link
Collaborator

@hjpotter92 we can merge #97 to get this pull request unblocked.

on:
pull_request:
# types: [closed]
branches:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjpotter92 should we trigger this on tag only?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. i'll add further conditions, once i'm able to generate the bundled assets in the workflow.

@hjpotter92 hjpotter92 force-pushed the hjp/releaser branch 2 times, most recently from 5b2c814 to ebd74b2 Compare February 28, 2025 08:37
Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, workflows checks are passing. Thank you for the help on this!

@eliteprox eliteprox merged commit 388eaa3 into main Feb 28, 2025
1 check passed
@hjpotter92 hjpotter92 deleted the hjp/releaser branch March 7, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants