Hide live preview button in storm #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase on main
oshi97
reviewed
Aug 24, 2023
oshi97
reviewed
Aug 24, 2023
oshi97
reviewed
Aug 25, 2023
alextaing
added a commit
that referenced
this pull request
Aug 25, 2023
This PR hides the Live preview button and stops pages dev from running when in CBD. This PR also resizes some of the icons in the action bar (info and viewport) since their height made the action bar stretch too tall. Tests were updated by adding `isWithinCBD` to the `virtual_yext-studio` mock. Also `isWithinCBD` was moved from `GitData` into `StudioData`, and was also updated in tests. See [this test site](https://www.yext.com/s/3350634/sitesgit/82218/b/hide-live-preview-button). **Live preview button does not appear in CBD and pages dev does not spawn**   **Live preview button does appear locally and pages dev does spawn**  <img width="958" alt="image" src="https://github.com/yext/studio/assets/59857107/8b494cc8-f489-4023-bb9f-5d2f204a001d"> J=SLAP-2891 TEST=manual
tmeyer2115
added a commit
that referenced
this pull request
Aug 28, 2023
## Features - An Info button was added next to the Live Preview button. When clicked, this displays the version number of Studio. (#346) - Number-type Props now have a Field Picker. (#344) ## Changes - The Live Preview button is now hidden when Studio is run in Storm. The PagesJS Dev Server is also not started. (#348) - Studio now supports PagesJS `^1.0.0-rc.1`. (#341) ## Bug Fixes - Immer is now correctly installed as a direct dependency of Studio. (#349)
oshi97
added a commit
that referenced
this pull request
Aug 30, 2023
This PR updates our parsing classes to avoid dynamically add source files to the project during initial parsing. Instead, we specify a path to the user's tsconfig, so that ts-morph can add them all at once on startup. Originally, I wanted to never dynamically add source files. However, this is still necessary for when we add new files, at least not without reworking at least a good portion of how we write to file. This speeds up initial parsing because every time a source file is added to the project (for instance via `addSourceFileAtPath` like we were doing), ts-morph will recreate the entire typescript compiler Project instance, which is a slow operation. I update the unit test workflow to split up the studio/studio-plugin tests, and also turn off coverage collection to speed up tests. We can turn it back on when we actually do something with it. We can also drop down the playwright test timeout now. The performance improvements here help, and also when we [updated the pages dev startup to use the api](#348) instead of a spawnSync. J=SLAP-2909 TEST=manual my local test-site has speed up to ~6 second start time, down from ~18 seconds --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides the Live preview button and stops pages dev from running when in CBD. This PR also resizes some of the icons in the action bar (info and viewport) since their height made the action bar stretch too tall.
Tests were updated by adding
isWithinCBDto thevirtual_yext-studiomock. AlsoisWithinCBDwas moved fromGitDataintoStudioData, and was also updated in tests.See this test site.
Live preview button does not appear in CBD and pages dev does not spawn
Live preview button does appear locally and pages dev does spawn
J=SLAP-2891
TEST=manual