Update to support ^1.0.0-rc.1 #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should not be merged until the next version of PagesJS is released to npm. This PR will also need to be updated to use the new PagesJS version. |
jwartofsky-yext
force-pushed
the
dev/support-yext-pages-1.0.0-rc.0
branch
from
fcbd0c5 to
4b960af
Compare
J=SLAP-2892 TEST=auto,manual Auto tests pass. Can run studio with npm run dev using ^1.0.0-rc.0 after modification. yext/pages@4cf67c9 Note that this change requires this update in PagesJS, so will either need to update locally or wait until the next PagesJS release.
Retested with npm run dev Studio appears and works as expected
jwartofsky-yext
force-pushed
the
dev/support-yext-pages-1.0.0-rc.0
branch
from
1716a06 to
fbfce13
Compare
jwartofsky-yext
changed the title
|
Tested with dyext/pages-1.0.0-rc.1 and npm run dev. All is working as expected. This should be good to go. |
This PR updates the Playwright test for rearranging elements so that it uses the new LocationPage. J=SLAP-2888 TEST=auto
oshi97
reviewed
Aug 22, 2023
oshi97
force-pushed
the
dev/support-yext-pages-1.0.0-rc.0
branch
from
61bc105 to
5a3822a
Compare
nmanu1
reviewed
Aug 22, 2023
jwartofsky-yext
commented
Aug 22, 2023
oshi97
approved these changes
Aug 22, 2023
nmanu1
reviewed
Aug 22, 2023
| @@ -33,7 +33,7 @@ | |||
| "@babel/preset-env": "^7.22.4", | |||
| "@babel/preset-react": "^7.22.3", | |||
| "@babel/preset-typescript": "^7.21.5", | |||
| "@yext/pages": "^1.0.0-beta.14", | |||
| "@yext/pages": "^1.0.0-rc.1", | |||
There was a problem hiding this comment.
I think the third party notices for studio-plugin need to be updated to reflect this change
tmeyer2115
added a commit
that referenced
this pull request
Aug 28, 2023
## Features - An Info button was added next to the Live Preview button. When clicked, this displays the version number of Studio. (#346) - Number-type Props now have a Field Picker. (#344) ## Changes - The Live Preview button is now hidden when Studio is run in Storm. The PagesJS Dev Server is also not started. (#348) - Studio now supports PagesJS `^1.0.0-rc.1`. (#341) ## Bug Fixes - Immer is now correctly installed as a direct dependency of Studio. (#349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support ^1.0.0-rc.0
J=SLAP-2892
TEST=auto,manual
Auto tests pass.
Can run studio with npm run dev using
^1.0.0-rc.0 after modification.
Note that this change requires this update in PagesJS, so will either need to update PagesJS locally or wait until the next PagesJS release.