Skip to content

Commit

Permalink
feat(codepipeline-actions): support timeout for `ManualApprovalActi…
Browse files Browse the repository at this point in the history
…on` (aws#33472)

### Issue # (if applicable)

Closes aws#33473 

### Reason for this change



The `TimeoutInMinutes` property, which is for the manual approval action, has been added to `ActionDeclaration` in CFn, but not yet added to `ManualApprovalAction` in CDK.

> A timeout duration in minutes that can be applied against the ActionType’s default timeout value specified in [Quotas for AWS CodePipeline](https://docs.aws.amazon.com/codepipeline/latest/userguide/limits.html). This attribute is available only to the manual approval ActionType.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-actiondeclaration.html#cfn-codepipeline-pipeline-actiondeclaration-timeoutinminutes

Other ref: https://docs.aws.amazon.com/codepipeline/latest/userguide/limits.html

> Manual approval action account level default timeout: 7 days
> 
> Note
> The default timeout for the manual approval action can be overridden for a specific action in the pipeline, and it is configurable up to 86400 minutes (60 days) with a minimum value of 5 minutes. For more information, see [ActionDeclaration](https://docs.aws.amazon.com/codepipeline/latest/APIReference/API_ActionDeclaration.html) in the CodePipeline API Reference.
> 
> When configured, this timeout is applied for the action. Otherwise, the account level default is used.

### Description of changes



Added `timeout` to `ManualApprovalActionProps` and other related properties (such as Action, FullActionDescriptor and Stage).

### Describe any new or updated permissions being added




### Description of how you validated changes



Both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
go-to-k authored and yashkh-amzn committed Feb 21, 2025
1 parent 38d24b3 commit 5365e1e
Show file tree
Hide file tree
Showing 13 changed files with 500 additions and 88 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@
"PipelineC660917D": {
"Type": "AWS::CodePipeline::Pipeline",
"Properties": {
"ArtifactStore": {
"Location": {
"Ref": "Bucket83908E77"
},
"Type": "S3"
},
"RoleArn": {
"Fn::GetAtt": [
"PipelineRoleD68726F7",
Expand Down Expand Up @@ -156,18 +162,13 @@
"Arn"
]
},
"RunOrder": 1
"RunOrder": 1,
"TimeoutInMinutes": 10
}
],
"Name": "Approve"
}
],
"ArtifactStore": {
"Location": {
"Ref": "Bucket83908E77"
},
"Type": "S3"
}
]
},
"DependsOn": [
"PipelineRoleDefaultPolicyC7A05455",
Expand Down Expand Up @@ -347,11 +348,11 @@
"PipelineApproveManualApprovalTopicResourceadamruka85gmailcom202874CD": {
"Type": "AWS::SNS::Subscription",
"Properties": {
"Endpoint": "[email protected]",
"Protocol": "email",
"TopicArn": {
"Ref": "PipelineApproveManualApprovalTopicResourceF5A35B20"
},
"Endpoint": "[email protected]"
}
}
}
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5365e1e

Please sign in to comment.