codepipeline-actions: support timeout for manual approval action #33473
Labels
@aws-cdk/aws-codepipeline-actions
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
go-to-k
added
feature-request
1 task
|
Thank you @go-to-k for your PR as always! |
pahud
added
p2
effort/medium
|
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
|
Comments on closed issues and PRs are hard for our team to see. |
yashkh-amzn
pushed a commit
to yashkh-amzn/aws-cdk
that referenced
this issue
Feb 21, 2025
…on` (aws#33472) ### Issue # (if applicable) Closes aws#33473 ### Reason for this change The `TimeoutInMinutes` property, which is for the manual approval action, has been added to `ActionDeclaration` in CFn, but not yet added to `ManualApprovalAction` in CDK. > A timeout duration in minutes that can be applied against the ActionType’s default timeout value specified in [Quotas for AWS CodePipeline](https://docs.aws.amazon.com/codepipeline/latest/userguide/limits.html). This attribute is available only to the manual approval ActionType. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-actiondeclaration.html#cfn-codepipeline-pipeline-actiondeclaration-timeoutinminutes Other ref: https://docs.aws.amazon.com/codepipeline/latest/userguide/limits.html > Manual approval action account level default timeout: 7 days > > Note > The default timeout for the manual approval action can be overridden for a specific action in the pipeline, and it is configurable up to 86400 minutes (60 days) with a minimum value of 5 minutes. For more information, see [ActionDeclaration](https://docs.aws.amazon.com/codepipeline/latest/APIReference/API_ActionDeclaration.html) in the CodePipeline API Reference. > > When configured, this timeout is applied for the action. Otherwise, the account level default is used. ### Description of changes Added `timeout` to `ManualApprovalActionProps` and other related properties (such as Action, FullActionDescriptor and Stage). ### Describe any new or updated permissions being added ### Description of how you validated changes Both unit and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the feature
The
TimeoutInMinutesproperty, which is for the manual approval action, has been added toActionDeclarationin CFn, but not yet added toManualApprovalActionin CDK.https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-actiondeclaration.html#cfn-codepipeline-pipeline-actiondeclaration-timeoutinminutes
Other ref: https://docs.aws.amazon.com/codepipeline/latest/userguide/limits.html
Use Case
The default timeout for the manual approval action is 7 days, but that often be too long or too short.
Proposed Solution
Added
timeouttoManualApprovalActionPropsand other related properties (such as Action, FullActionDescriptor and Stage).Other Information
No response
Acknowledgements
CDK version used
2.178.1
Environment details (OS name and version, etc.)
Mac
The text was updated successfully, but these errors were encountered: