Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: don't continue running when cancelled #4290

Merged
merged 1 commit into from
Mar 29, 2022
Merged

ci: don't continue running when cancelled #4290

merged 1 commit into from
Mar 29, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Mar 29, 2022 •
edited
Loading

What's the problem this PR addresses?

When cancelling a workflow it will continue running steps using always() which requires another cancelation and is quite annoying. This became more prominent with #4286.

How did you fix it?

Replaced always() with success() || failure() which matches what #3643 wanted.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner March 29, 2022 18:21
@arcanis arcanis merged commit 9706355 into master Mar 29, 2022
@arcanis arcanis deleted the merceyz/ci/cancel-jobs branch March 29, 2022 20:22
merceyz added a commit that referenced this pull request Apr 24, 2023
@merceyz
ci: don't continue running when cancelled (#4290)
bbf001c
@legobeat legobeat mentioned this pull request Jul 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcanis arcanis Awaiting requested review from arcanis arcanis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @arcanis