Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove leftover test code #4246

Merged
merged 1 commit into from
Mar 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pnp.cjs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions .yarn/patches/lodash-npm-4.17.21-6382451519.patch

This file was deleted.

30 changes: 30 additions & 0 deletions .yarn/versions/dd585676.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
releases:
"@yarnpkg/cli": patch
"@yarnpkg/parsers": patch
"@yarnpkg/plugin-pnp": patch
"@yarnpkg/pnp": patch

declined:
- "@yarnpkg/esbuild-plugin-pnp"
- "@yarnpkg/plugin-compat"
- "@yarnpkg/plugin-constraints"
- "@yarnpkg/plugin-dlx"
- "@yarnpkg/plugin-essentials"
- "@yarnpkg/plugin-init"
- "@yarnpkg/plugin-interactive-tools"
- "@yarnpkg/plugin-nm"
- "@yarnpkg/plugin-npm-cli"
- "@yarnpkg/plugin-pack"
- "@yarnpkg/plugin-patch"
- "@yarnpkg/plugin-pnpm"
- "@yarnpkg/plugin-stage"
- "@yarnpkg/plugin-typescript"
- "@yarnpkg/plugin-version"
- "@yarnpkg/plugin-workspace-tools"
- "@yarnpkg/builder"
- "@yarnpkg/core"
- "@yarnpkg/doctor"
- "@yarnpkg/nm"
- "@yarnpkg/pnpify"
- "@yarnpkg/sdks"
- "@yarnpkg/shell"
72 changes: 20 additions & 52 deletions packages/yarnpkg-parsers/sources/grammars/shell.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/yarnpkg-parsers/sources/grammars/shell.pegjs
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ GlobText

EnvVariable
= [a-zA-Z0-9_]+ { return text() }
/ [A-Za-z0-9_]+ { return text() }
Copy link
Member Author

@merceyz merceyz Mar 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was added in c225c1f without any tests or explanation so out it goes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it was just a no-op to change the generated syntax, to check how it merged


Identifier
= [$@*?#a-zA-Z0-9_-]+ { return text() }
Expand Down
2 changes: 1 addition & 1 deletion packages/yarnpkg-pnp/sources/hook.js

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions packages/yarnpkg-pnp/sources/loader/_entryPoint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ declare var $$SETUP_STATE: (hrs: typeof hydrateRuntimeState, basePath?: NativePa
const localFs: typeof fs = {...fs};
const nodeFs = new NodeFS(localFs);

// This is just a test, I'll remove it asap
(nodeFs as any).__test = true;

const defaultRuntimeState = $$SETUP_STATE(hydrateRuntimeState);
const defaultPnpapiResolution = __filename;

Expand Down
1 change: 0 additions & 1 deletion test.md

This file was deleted.