Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove leftover test code #4246

Merged
merged 1 commit into from
Mar 19, 2022
Merged

chore: remove leftover test code #4246

merged 1 commit into from
Mar 19, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Mar 19, 2022

What's the problem this PR addresses?

Some leftovers has snuck into the codebase in c225c1f and #4218

How did you fix it?

Removed it.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@@ -176,7 +176,6 @@ GlobText

EnvVariable
= [a-zA-Z0-9_]+ { return text() }
/ [A-Za-z0-9_]+ { return text() }
Copy link
Member Author

@merceyz merceyz Mar 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was added in c225c1f without any tests or explanation so out it goes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it was just a no-op to change the generated syntax, to check how it merged

@merceyz merceyz requested a review from arcanis March 19, 2022 00:22
@arcanis arcanis merged commit 10036f5 into master Mar 19, 2022
@arcanis arcanis deleted the merceyz/chore/cleanup branch March 19, 2022 08:52
merceyz added a commit that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants