Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel dragger workaround for Safari #3799

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

TomTirapani
Copy link
Member

Safari is not setting buttons or button to 1 on Drag events, which is causing our Panel resizing to early out.
See: #3797

This workaround adds a fallback check to the deprecated MouseEvent.which property, which is being set:
https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/which#value_for_mouseevent_non-standard

As a deprecated API we obviously should not rely on it, but I think its safe to use as fall back for this specific issue in lieu of a better solution.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler
Copy link
Member

lbwexler commented Oct 4, 2024

Thanks for the quick turnaround here Tom. I think this is very pragmatic.

@lbwexler lbwexler merged commit 4bbf346 into develop Oct 4, 2024
2 checks passed
@lbwexler lbwexler deleted the panelResizeDragSafari branch October 4, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants