Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable panels / splitters broken in desktop Safari #3797

Closed
amcclain opened this issue Oct 1, 2024 · 3 comments
Closed

Resizable panels / splitters broken in desktop Safari #3797

amcclain opened this issue Oct 1, 2024 · 3 comments
Assignees

Comments

@amcclain
Copy link
Member

amcclain commented Oct 1, 2024

No description provided.

@lbwexler
Copy link
Member

lbwexler commented Oct 3, 2024

This seems concerning -- think we should understand what's happening here sooner rather than later

@TomTirapani
Copy link
Member

I'm looking into this... it seems this test is failing:
https://github.com/xh/hoist-react/blob/develop/desktop/cmp/panel/impl/dragger/DraggerModel.ts#L256-L258

DragEvent's buttons is 0 in Safari, but 1 in Chrome, which causes us to exit out of the drag early here:
https://github.com/xh/hoist-react/blob/develop/desktop/cmp/panel/impl/dragger/DraggerModel.ts#L93-L96

Investigating why / how this could be the case, and what we can do about it. Seems like a low-level Safari bug to me - will post findings here

@TomTirapani
Copy link
Member

I came up with a workaround which resolves the issue:
#3799

I'll keep looking for a better solution / more information

@lbwexler lbwexler closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants