Boulac PBL tendency should not be added to previous value #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudhia
changed the title
|
@dudhia |
|
Yes, this is a b it tentative until the test is done. I will try to do that soon. |
weiwangncar
approved these changes
Apr 6, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…1453) TYPE: bug fix (no effect) KEYWORDS: BouLac PBL option SOURCE: Internal (reported by Xinzhong Liang) DESCRIPTION OF CHANGES: Problem: PBL tendency was added to old value (no sign that this was causing problems as array may have been zero): e.g. ``` rthblten(ix,iz,iy)=rthblten(ix,iz,iy)+(th1D(iz)-th_phy(ix,iz,iy))/dt ``` This could have problems if BLDT is used Solution: Do not add to old value: ``` rthblten(ix,iz,iy)=(th1D(iz)-th_phy(ix,iz,iy))/dt ``` ISSUE: Fixes part of wrf-model#1297 (not closed yet) LIST OF MODIFIED FILES: phys/module_bl_boulac.F TESTS CONDUCTED: 1. Tests with and without change Jan 2000 case, identical after one hour. 2. Jenkins OK. RELEASE NOTE: A minor fix to BouLac PBL tendency cleans up the assignment, no longer assuming that the tendency is cumulative (no effect).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix (no effect)
KEYWORDS: BouLac PBL option
SOURCE: Internal (reported by Xinzhong Liang)
DESCRIPTION OF CHANGES:
Problem:
PBL tendency was added to old value (no sign that this was causing problems as array may have been zero): e.g.
This could have problems if BLDT is used
Solution:
Do not add to old value:
ISSUE:
Fixes part of #1297 (not closed yet)
LIST OF MODIFIED FILES:
phys/module_bl_boulac.F
TESTS CONDUCTED:
RELEASE NOTE: A minor fix to BouLac PBL tendency cleans up the assignment, no longer assuming that the tendency is cumulative (no effect).