Issues reported by Xin-Zhong Liang #1297
Assignees
Comments
Merged
|
Not sure why this was closed. There are some left here.
…On Fri, Jan 15, 2021 at 10:30 AM smileMchen ***@***.***> wrote:
Closed #1297 <#1297> via b21c918
<b21c918>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1297 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77D3EZKC6QQMTGNKSGDS2B3UPANCNFSM4R55XZAA>
.
|
|
Reopened with remaining issue, also added issues reported by same user |
|
Just a heads-up. I am going to be putting in bug-fixes for the Boulac and UWPBL issues listed here soon. |
davegill
pushed a commit
that referenced
this issue
Apr 7, 2021
TYPE: bug fix (no effect) KEYWORDS: BouLac PBL option SOURCE: Internal (reported by Xinzhong Liang) DESCRIPTION OF CHANGES: Problem: PBL tendency was added to old value (no sign that this was causing problems as array may have been zero): e.g. ``` rthblten(ix,iz,iy)=rthblten(ix,iz,iy)+(th1D(iz)-th_phy(ix,iz,iy))/dt ``` This could have problems if BLDT is used Solution: Do not add to old value: ``` rthblten(ix,iz,iy)=(th1D(iz)-th_phy(ix,iz,iy))/dt ``` ISSUE: Fixes part of #1297 (not closed yet) LIST OF MODIFIED FILES: phys/module_bl_boulac.F TESTS CONDUCTED: 1. Tests with and without change Jan 2000 case, identical after one hour. 2. Jenkins OK. RELEASE NOTE: A minor fix to BouLac PBL tendency cleans up the assignment, no longer assuming that the tendency is cumulative (no effect).
davegill
pushed a commit
that referenced
this issue
Apr 8, 2021
…cy (#1465) TYPE: bug fix KEYWORDS: UW PBL, input radiative tendency fix SOURCE: internal (reported by Xinzhong Liang) DESCRIPTION OF CHANGES: Problem: The top-down mixing in this scheme requires a radiative temperature tendency but the theta tendency is provided. The error is small as this tendency is only used for clouds at the top of the PBL. Solution: Convert input radiative tendency from theta to T (exner multiplier included) qrl8( 1,kflip) = rthratenlw(i,k,j) _*exner(i,k,j)_ * cpair * dp ISSUE: Fixes one of the issues in #1297 (some still need investigating) LIST OF MODIFIED FILES: M phys/module_bl_camuwpbl_driver.F TESTS CONDUCTED: 1. Tests confirm small impact. 2. Jenkins testing is OK. RELEASE NOTE: UW PBL: input radiative tendency corrected to be T tendency instead of theta (small effect of temperature vs theta up through the top of the PBL).
|
last issue here |
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this issue
Apr 4, 2024
…rf-model#1313) TYPE: bug fix KEYWORDS: sea-ice fraction option, QSFC calculation, MYJSFC, QNSESFC SOURCE: Xin-Zhong Liang DESCRIPTION OF CHANGES: Problem: Incorrect parentheses in weighted average Solution: Fixed parentheses Effect: Test by Kevin Manning indicates small effect. ISSUE: For use when this PR closes an issue. Fixes wrf-model#1297 (part) LIST OF MODIFIED FILES: M phys/module_surface_driver.F TESTS CONDUCTED: Test by Kevin Manning shows small impact. Jenkins test (TBD) RELEASE NOTE: Fix incorrect parentheses in weighted average for QSFC when sea-ice fraction is used with MYJSFC and QNSESFC surface layer physics.
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this issue
Apr 4, 2024
…1453) TYPE: bug fix (no effect) KEYWORDS: BouLac PBL option SOURCE: Internal (reported by Xinzhong Liang) DESCRIPTION OF CHANGES: Problem: PBL tendency was added to old value (no sign that this was causing problems as array may have been zero): e.g. ``` rthblten(ix,iz,iy)=rthblten(ix,iz,iy)+(th1D(iz)-th_phy(ix,iz,iy))/dt ``` This could have problems if BLDT is used Solution: Do not add to old value: ``` rthblten(ix,iz,iy)=(th1D(iz)-th_phy(ix,iz,iy))/dt ``` ISSUE: Fixes part of wrf-model#1297 (not closed yet) LIST OF MODIFIED FILES: phys/module_bl_boulac.F TESTS CONDUCTED: 1. Tests with and without change Jan 2000 case, identical after one hour. 2. Jenkins OK. RELEASE NOTE: A minor fix to BouLac PBL tendency cleans up the assignment, no longer assuming that the tendency is cumulative (no effect).
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this issue
Apr 4, 2024
…cy (wrf-model#1465) TYPE: bug fix KEYWORDS: UW PBL, input radiative tendency fix SOURCE: internal (reported by Xinzhong Liang) DESCRIPTION OF CHANGES: Problem: The top-down mixing in this scheme requires a radiative temperature tendency but the theta tendency is provided. The error is small as this tendency is only used for clouds at the top of the PBL. Solution: Convert input radiative tendency from theta to T (exner multiplier included) qrl8( 1,kflip) = rthratenlw(i,k,j) _*exner(i,k,j)_ * cpair * dp ISSUE: Fixes one of the issues in wrf-model#1297 (some still need investigating) LIST OF MODIFIED FILES: M phys/module_bl_camuwpbl_driver.F TESTS CONDUCTED: 1. Tests confirm small impact. 2. Jenkins testing is OK. RELEASE NOTE: UW PBL: input radiative tendency corrected to be T tendency instead of theta (small effect of temperature vs theta up through the top of the PBL).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
QSFC calculation for sea ice and MYJ options need to be corrected
EXCH_H calculation for MYJ, GBM and ACM2 need to be checked, possibly off by one level. Also check Boulac.
The text was updated successfully, but these errors were encountered: