Change default fractional_seaice option from 0 to 1 #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weiwangncar |
|
@weiwangncar |
davegill
reviewed
Feb 18, 2021
davegill
approved these changes
Feb 18, 2021
|
|
kkeene44
added a commit
that referenced
this pull request
Apr 14, 2021
…real cases (#1468) TYPE: no impact KEYWORDS: fractional_seaice, registry, Registry.EM_COMMON, namelist.input, SLAB SOURCE: internal DESCRIPTION OF CHANGES: Problem: The namelist parameter "fractional_seaice" was recently modified in the Registry.EM_COMMON file to be set to "on" (1) by default (commit 0fff69a, PR #1401 "Change default fractional_seaice option from 0 to 1". However, if using the SLAB scheme, fractional_seaice must be turned off, which causes problems for some of the default idealized cases. Additionally, some other cases where users are running with the SLAB scheme (and not realizing it's turned on by default), would cause lots of user difficulty and confusion. Solution: Set fractional_seaice back to 0 (off) in Registry.EM_COMMON, but add it (and turned on) to three of the default namelists in the test/em_real directory as examples. LIST OF MODIFIED FILES: M test/em_real/namelist.input M test/em_real/namelist.input.global M test/em_real/namelist.input.jan00 M Registry/Registry.EM_COMMON TESTS CONDUCTED: The namelist changes have no impact on the build or run phases of the model. When fractional seaice was activated by default, this uncovered several problems that were previously addressed. Reverting the default fractional seaice setting back to zero (OFF) is not problematic. f87b449, #1422 "Fix for fractional_seaice option, again" 476990a, #1457 "Fix for fractional seaice using MYJ and QNSE surface layer with MYNN PBL"
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: enhancement KEYWORDS: namelist fractional_seaice, default, replacing original PR#1128 SOURCE: Internal DESCRIPTION OF CHANGES: Since GFS, the most commonly used input data source, has been providing fractional seaice data for a while, it seems reasonable to make the default option for fractional_seaice to be 1. Both ERA5 and ERA-Interim provide fractional seaice data, too. When fractional seaice data is available, this option should be used in general. Turning on the fractional seaice flag broke many MPI vs OpenMP comparison tests. This led to the finding that the option is not thread safe for a number surface layer physics options: revised MM5, original MM5, MYJ, QNSE and PX (sf_sfclay_physics = 1, 91, 2, 4, and 7). This PR additionally provides the fix for these options. LIST OF MODIFIED FILES: M Registry/Registry.EM_COMMON M phys/module_surface_driver.F TESTS CONDUCTED: Jenkins test all pass. RELEASE NOTE: The default option for using fractional_seaice has been changed from 0 (off) to 1 (on) starting with release v4.3. In addition, several surface layer schemes are made thread safe if fractional seaice option is used. These are revised MM5, original MM5, MYJ, QNSE and PX surface layer scheme (sf_sfclay_physics = 1, 91, 2, 4, and 7).
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…real cases (wrf-model#1468) TYPE: no impact KEYWORDS: fractional_seaice, registry, Registry.EM_COMMON, namelist.input, SLAB SOURCE: internal DESCRIPTION OF CHANGES: Problem: The namelist parameter "fractional_seaice" was recently modified in the Registry.EM_COMMON file to be set to "on" (1) by default (commit 0fff69a, PR wrf-model#1401 "Change default fractional_seaice option from 0 to 1". However, if using the SLAB scheme, fractional_seaice must be turned off, which causes problems for some of the default idealized cases. Additionally, some other cases where users are running with the SLAB scheme (and not realizing it's turned on by default), would cause lots of user difficulty and confusion. Solution: Set fractional_seaice back to 0 (off) in Registry.EM_COMMON, but add it (and turned on) to three of the default namelists in the test/em_real directory as examples. LIST OF MODIFIED FILES: M test/em_real/namelist.input M test/em_real/namelist.input.global M test/em_real/namelist.input.jan00 M Registry/Registry.EM_COMMON TESTS CONDUCTED: The namelist changes have no impact on the build or run phases of the model. When fractional seaice was activated by default, this uncovered several problems that were previously addressed. Reverting the default fractional seaice setting back to zero (OFF) is not problematic. f87b449, wrf-model#1422 "Fix for fractional_seaice option, again" 476990a, wrf-model#1457 "Fix for fractional seaice using MYJ and QNSE surface layer with MYNN PBL"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: namelist fractional_seaice, default, replacing original PR#1128
SOURCE: Internal
DESCRIPTION OF CHANGES:
Since GFS, the most commonly used input data source, has been providing fractional seaice
data for a while, it seems reasonable to make the default option for fractional_seaice to be 1.
This should also help our general users. Both ERA5 and ERA-Interim provide fractional seaice
data, too.
Turning on the fractional seaice flag broke many MPI vs OpenMP comparison tests. This led to the finding that the
option is not thread safe for a number surface layer physics options: revised MM5, original MM5, MYJ, QNSE and PX (sf_sfclay_physics = 1, 91, 2, 4, and 7). This PR additionally provides the fix for these options.
LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M phys/module_surface_driver.F
TESTS CONDUCTED:
RELEASE NOTE: The default option for using fractional_seaice has been changed from 0 (off) to 1 (on) starting with release v4.3. In addition, several surface layer schemes are made thread safe if fractional seaice option is used. These are revised MM5, original MM5, MYJ, QNSE and PX surface layer scheme (sf_sfclay_physics = 1, 91, 2, 4, and 7).