Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of fractional_seaice from 0 to 1 #1128

Closed
wants to merge 4 commits into from
Closed

Change default value of fractional_seaice from 0 to 1 #1128

wants to merge 4 commits into from

Conversation

weiwangncar
Copy link
Collaborator

@weiwangncar weiwangncar commented Mar 9, 2020

Breaks several regression tests

em_real 60NE MPI (serial and openmp are OK)

moving nest case 01 MPI

openmp b4b broken with 07NE, 20, 20NE, 60, 71, 78, tropical

TYPE: enhancement

KEYWORDS: namelist fractional_seaice, default

SOURCE: Internal

DESCRIPTION OF CHANGES:
Since GFS, the most commonly used input data source, has been providing fractional seaice
data for a while, it seems reasonable to make the default option for fractional_seaice to be 1.
This should also help our general users. Both ERA5 and ERA-Interim provide fractional seaice
data, too.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON

TESTS CONDUCTED:
Reg test:

RELEASE NOTE: The default option for using fractional_seaice has been changed from 0 (off) to 1 (on) starting with release v4.2.

@weiwangncar weiwangncar requested a review from a team as a code owner March 9, 2020 17:41
@davegill davegill changed the title Change default value from fractional_seaice from 0 to 1 Change default value of fractional_seaice from 0 to 1 Mar 9, 2020
@davegill
Copy link
Contributor

davegill commented Mar 11, 2020

@weiwangncar
Wei,
Changing this default causes some troubles.

-------------- FATAL CALLED ---------------
FATAL CALLED FROM FILE:  <stdin>  LINE:    2317
SLAB scheme cannot be used with fractional seaice
-------------------------------------------

Please add either

  1. a check_a_mundo test that turns off the fractional seaice if the LSM is the slab model
  2. or a trapped fatal error in check_a_mundo (so that we do not have to do them one at a time via physics_init)

@davegill
Copy link
Contributor

@weiwangncar
Wei,
This mod breaks the regression test, as there are a number of sf_surface_physics=1 options for the em_real cases. I need to put in the fractional_seaice = 0 for all of those. Until then, with this mod, there will be about 30 FAILs.

@davegill
Copy link
Contributor

@weiwangncar
Wei,
It also seems that PX does not always work well with fractional_seaice. Maybe due to the moisture nudging?

@davegill
Copy link
Contributor

Replaced by: Change default fractional_seaice option from 0 to 1 (#1401)

@davegill davegill closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants