Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release 1.52.1 to develop #3468

Merged
merged 10 commits into from
May 7, 2021
Merged

Merge release 1.52.1 to develop #3468

merged 10 commits into from
May 7, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented May 7, 2021

This PR merges changes for release 1.52.1 back to develop to brink it up to date with trunk.

To test: Run the demo app to ensure the editor launches and runs successfully.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun dcalhoun marked this pull request as ready for review May 7, 2021 21:56
@dcalhoun dcalhoun requested review from cameronvoell and fluiddot May 7, 2021 21:56
@dcalhoun dcalhoun enabled auto-merge May 7, 2021 21:57
cameronvoell
cameronvoell approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified I see the strings.xml and GutenbergNativeTranslations.swift updates and version updates as expected.

Thanks for wrangling this @dcalhoun and @fluiddot

@dcalhoun dcalhoun merged commit 90bc8a1 into develop May 7, 2021
@dcalhoun dcalhoun deleted the merge_release_1.52.1_to_develop branch May 7, 2021 23:09
@fluiddot fluiddot added this to the 1.53.0 (17.4) milestone May 14, 2021
@AmandaRiu AmandaRiu mentioned this pull request May 14, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@fluiddot fluiddot Awaiting requested review from fluiddot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.53.0 (17.4)
Development

Successfully merging this pull request may close these issues.
3 participants
@dcalhoun @cameronvoell @fluiddot