Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.52.1 #3467

Merged
merged 7 commits into from
May 7, 2021
Merged

Release 1.52.1 #3467

merged 7 commits into from
May 7, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 7, 2021

Release for Gutenberg Mobile 1.52.1

Related PRs

- Aztec-iOS: https://github.com/wordpress-mobile/AztecEditor-iOS/pull/
- Aztec-Android: https://github.com/wordpress-mobile/AztecEditor-Android/pull

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

This beta fix only contains fixes for the generated localized strings files that included extra strings in the last version 1.52.0:

The process followed to fix them consisted in:

  1. Add *.js,*.php to the --exclude argument of the makepot commands located here.
  2. Run the command npm run genstrings
  3. Compare the generated files with the ones committed for the version 1.51.1 (strings.xml, GutenbergNativeTranslations.swift)
  4. Include the missing strings in the newly generated files that were in 1.51.1

Here are the diffs for the localized strings files between 1.52.1 and 1.51.1 as a double check to verify that we're not missing strings:

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 7, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot requested a review from dcalhoun May 7, 2021 17:39
@fluiddot fluiddot marked this pull request as ready for review May 7, 2021 17:41
@fluiddot
Copy link
Contributor Author

fluiddot commented May 7, 2021

Looks like the job for building and publishing the bundle to S3 is not working 😭:

 What went wrong:
Could not determine the dependencies of task ':react-native-bridge:compileReleaseAidl'.
> Could not resolve all task dependencies for configuration ':react-native-bridge:releaseCompileClasspath'.
   > Could not resolve com.facebook.react:react-native:0.61.5.
     Required by:
         project :react-native-bridge
         project :react-native-bridge > org.wordpress-mobile.gutenberg-mobile:react-native-aztec:3467-e95b5144cf4cd6d9566f3b6f484f14754ce32f48
      > Could not resolve com.facebook.react:react-native:0.61.5.
         > Could not get resource 'https://dl.bintray.com/wordpress-mobile/react-native-mirror/com/facebook/react/react-native/0.61.5/react-native-0.61.5.pom'.
            > Could not GET 'https://dl.bintray.com/wordpress-mobile/react-native-mirror/com/facebook/react/react-native/0.61.5/react-native-0.61.5.pom'. Received status code 403 from server: Forbidden
      > Could not resolve com.facebook.react:react-native:0.61.5.
         > Could not get resource 'https://dl.bintray.com/wordpress-mobile/maven/com/facebook/react/react-native/0.61.5/react-native-0.61.5.pom'.
            > Could not GET 'https://dl.bintray.com/wordpress-mobile/maven/com/facebook/react/react-native/0.61.5/react-native-0.61.5.pom'. Received status code 403 from server: Forbidden
      > Could not resolve com.facebook.react:react-native:0.61.5.
         > Could not get resource 'https://a8c-libs.s3.amazonaws.com/android/com/facebook/react/react-native/0.61.5/react-native-0.61.5.pom'.
            > Could not GET 'https://a8c-libs.s3.amazonaws.com/android/com/facebook/react/react-native/0.61.5/react-native-0.61.5.pom'. Received status code 403 from server: Forbidden

@dcalhoun Probably we should apply the fixes from this PR.

@cameronvoell Did you have this issue in 1.52.0 release? how did you solve it?

EDIT: @cameronvoell will cherry-pick the fixes for the job issue 🎊 .

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Smoke tested on a iPhone SE (build 47372) and Samsung Galaxy S20 (build 105077).

@dcalhoun dcalhoun merged commit 475319a into trunk May 7, 2021
@dcalhoun dcalhoun deleted the release/1.52.1 branch May 7, 2021 20:02
@dcalhoun dcalhoun mentioned this pull request May 7, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants