Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gifu to 3.3.1 #21161

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Update Gifu to 3.3.1 #21161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57af5dd
Fix a new warning in animate(withGIFData:)
kean Jul 21, 2023
85b92f3
Update Gifu to 3.3.1
kean Jul 21, 2023
d4c4c29
Merge branch 'trunk' into task/update-gifu
kean Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ abstract_target 'Apps' do
## Third party libraries
## =====================
##
pod 'Gifu', '3.2.0'
pod 'Gifu', '3.3.1'

app_center_version = '~> 4.1'
app_center_configurations = %w[Release-Internal Release-Alpha]
Expand Down
8 changes: 4 additions & 4 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ PODS:
- ReactCommon/turbomodule/core (= 0.69.4)
- fmt (6.2.1)
- FSInteractiveMap (0.1.0)
- Gifu (3.2.0)
- Gifu (3.3.1)
- glog (0.3.5)
- GoogleSignIn (6.0.2):
- AppAuth (~> 1.4)
Expand Down Expand Up @@ -553,7 +553,7 @@ DEPENDENCIES:
- FBLazyVector (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/v1.100.1/third-party-podspecs/FBLazyVector.podspec.json`)
- FBReactNativeSpec (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/v1.100.1/third-party-podspecs/FBReactNativeSpec/FBReactNativeSpec.podspec.json`)
- FSInteractiveMap (from `https://github.com/wordpress-mobile/FSInteractiveMap.git`, tag `0.2.0`)
- Gifu (= 3.2.0)
- Gifu (= 3.3.1)
- glog (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/v1.100.1/third-party-podspecs/glog.podspec.json`)
- Gridicons (~> 1.1.0)
- Gutenberg (from `https://github.com/wordpress-mobile/gutenberg-mobile.git`, tag `v1.100.1`)
Expand Down Expand Up @@ -810,7 +810,7 @@ SPEC CHECKSUMS:
FBReactNativeSpec: 03365206a695e76184146098efecb19a07f98ffc
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
FSInteractiveMap: a396f610f48b76cb540baa87139d056429abda86
Gifu: 7bcb6427457d85e0b4dff5a84ec5947ac19a93ea
Gifu: 416d4e38c4c2fed012f019e0a1d3ffcb58e5b842
glog: 741689bdd65551bc8fb59d633e55c34293030d3e
GoogleSignIn: fd381840dbe7c1137aa6dc30849a5c3e070c034a
Gridicons: 17d660b97ce4231d582101b02f8280628b141c9a
Expand Down Expand Up @@ -895,6 +895,6 @@ SPEC CHECKSUMS:
ZendeskSupportSDK: 3a8e508ab1d9dd22dc038df6c694466414e037ba
ZIPFoundation: ae5b4b813d216d3bf0a148773267fff14bd51d37

PODFILE CHECKSUM: 5238db288b233109c5666c6dfc4557a393fb3dd0
PODFILE CHECKSUM: 219c9d34b99c2ffae24b5f8f02060f2cac26145c

COCOAPODS: 1.12.1
4 changes: 2 additions & 2 deletions WordPress/Classes/ViewRelated/Media/CachedAnimatedImageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,9 @@ public class CachedAnimatedImageView: UIImageView, GIFAnimatable {
animatedGifData = data
DispatchQueue.main.async() {
self.setFrameBufferCount(self.gifPlaybackStrategy.frameBufferCount)
self.animate(withGIFData: data) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If fixes the this new-ish warning: https://github.com/apple/swift-evolution/blob/main/proposals/0286-forward-scan-trailing-closures.md

self.animate(withGIFData: data, preparationBlock: {
success?()
}
})
}
}

Expand Down