-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gifu to 3.3.1 #21161
Update Gifu to 3.3.1 #21161
Conversation
@@ -221,9 +221,9 @@ public class CachedAnimatedImageView: UIImageView, GIFAnimatable { | |||
animatedGifData = data | |||
DispatchQueue.main.async() { | |||
self.setFrameBufferCount(self.gifPlaybackStrategy.frameBufferCount) | |||
self.animate(withGIFData: data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If fixes the this new-ish warning: https://github.com/apple/swift-evolution/blob/main/proposals/0286-forward-scan-trailing-closures.md
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr21161-d4c4c29 | |
Version | 22.8 | |
Bundle ID | org.wordpress.alpha | |
Commit | d4c4c29 | |
App Center Build | WPiOS - One-Offs #6477 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr21161-d4c4c29 | |
Version | 22.8 | |
Bundle ID | com.jetpack.alpha | |
Commit | d4c4c29 | |
App Center Build | jetpack-installable-builds #5508 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortunately, I fixed this crash in Gifu two years ago 😃
Okay 😅
Power of open source integrating your own changes from 2 years ago 👏
Fixes #21160
Fortunately, I fixed this crash in Gifu two years ago 😃
To test:
The crash is a race condition and you have to be very unlucky to reproduce it.
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.